940854 - hb-font-private.hh:364:17: error: use of undeclared identifier 'snprintf'

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jan Beich]

In file included from gfx/harfbuzz/src/Unified_cpp_gfx_harfbuzz_src0.cpp:3:
In file included from gfx/harfbuzz/src/hb-face.cc:31:
In file included from gfx/harfbuzz/src/hb-ot-layout-private.hh:36:
gfx/harfbuzz/src/hb-font-private.hh:364:17: error:
      use of undeclared identifier 'snprintf'
    if (size && snprintf (s, size, "gid%u", glyph) < 0)
                ^

Comment 1

[Benoit Girard (:BenWa)]

Can you post a patch that fixes the issue for you and I'll land it tomorrow?

Comment 2

[Jan Beich]

hb-blob.c defines _POSIX_C_SOURCE which on DragonFly and FreeBSD influences visibility of C standard functions.

  /* sys/cdefs.h */
  #elif _POSIX_C_SOURCE >= 199309
  #define	__POSIX_VISIBLE		199309
  #define	__ISO_C_VISIBLE		1990

  /* stdio.h */
  #if __ISO_C_VISIBLE >= 1999
  int	 snprintf(char * __restrict, size_t, const char * __restrict,
              ...) __printflike(3, 4);

However, building hb-blob.c separately leads to

  In file included from gfx/harfbuzz/src/Unified_cpp_gfx_harfbuzz_src0.cpp:16:
  In file included from gfx/harfbuzz/src/hb-shape-plan.cc:35:
  gfx/harfbuzz/src/hb-shaper-list.hh:39:1: error:
        redefinition of 'hb_ot_shaper_face_data_ensure'
  HB_SHAPER_IMPLEMENT (ot) /* <--- This is our main OpenType shaper. */
  ^
  gfx/harfbuzz/src/hb-shape-plan.cc:33:2: note:
        expanded from macro 'HB_SHAPER_IMPLEMENT'
          HB_SHAPER_DATA_ENSURE_DECLARE(shaper, face) \
          ^
  gfx/harfbuzz/src/hb-shaper-private.hh:88:20: note:
        expanded from macro 'HB_SHAPER_DATA_ENSURE_DECLARE'
  static inline bool \
                     ^
  <scratch space>:177:1: note: expanded from here
  hb_ot_shaper_face_data_ensure
  ^
  gfx/harfbuzz/src/hb-ot-layout.cc:44:1: note:
        previous definition is here
  HB_SHAPER_DATA_ENSURE_DECLARE(ot, face)
  ^
  gfx/harfbuzz/src/hb-shaper-private.hh:88:20: note:
        expanded from macro 'HB_SHAPER_DATA_ENSURE_DECLARE'
  static inline bool \
                     ^
  <scratch space>:135:1: note: expanded from here
  hb_ot_shaper_face_data_ensure
  ^

Comment 3

[Jan Beich]

Attachment: don't unify a few more files

Can you push to Try as well?

Comment 4

[Benoit Girard (:BenWa)]

*sad face* ok

Comment 5

[Benoit Girard (:BenWa)]

(In reply to Benoit Girard (:BenWa) from comment #4)
> *sad face* ok

err that was regarding having to move these files out of unified source, not pushing to try :). Thanks for the help!

Comment 6

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=84ea4991f389

Comment 7

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21e8bf80f98d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21e8bf80f98d