940897 - [settings] built-in keyboard of type 'Number': Type always shown in English (not using localization)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.2.0.0-prerelease 20131119224416 on Keon

With a different language than English for the user interface, opening Settings > Keyboards > Selected Keyboards still shows the type of the built-in numbers keyboard as "Number" (in English).

apps/keyboard/manifest.webapp defines only the number keyboard, so that's likely the issue.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The integration into apps/keyboard/manifest.webapp is likely also the reason for the keyboard showing the number layout on initialization when opened for the first time in an app during runtime.

Comment 2

[Axel Hecht [:Pike]]

This is a regression from bug 930371, and how the change of entry_points to inputs plays with multilocale.py.

I'll have a PR in a second that I think fixes this, sadly more code in multilocale.py.

Comment 3

[Axel Hecht [:Pike]]

Attachment: support inputs entry point for the keyboard app

This is only rudimentary tested, i.e., I've run make with LOCALE_BASEDIR and and LOCALES_FILE set, and inspected manifest.webapp to be OK.

Comment 4

[Jason Smith [:jsmith]]

Blocking for untranslated number keyboard having significant localization impact

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

[off topic] we should land multilocale.js ASAP, but I don't have enough time :(

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8335256 [details] [review]
support inputs entry point for the keyboard app

Looks good to me.
Thanks and sorry for the late change of changing entry_points to inputs.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8335256 [details] [review]
support inputs entry point for the keyboard app

looks good to me, r=yurenju

Comment 8

[Axel Hecht [:Pike]]

I'll need landing buddies for both master and v1.2, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/f936039df67b3f86463f70681dc9e71256d74823

John should take care of the uplift as part of his regular routine.

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f936039df67b3f86463f70681dc9e71256d74823 to:
v1.2: 6c755778a4595586f875edb02ecc262d093c0f93