940936 - Change - Use profile name in registry sync prefs for WindowsPrefSync.jsm

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Brian R. Bondy [:bbondy]]

We're currently syncing between all profile, but now that we're haring a profile we only need to sync per profile name.

p=1

Comment 1

[Marco Mucci [:MarcoM]]

Hey Brian, is this [block28] or [release28]?

Comment 2

[Marco Mucci [:MarcoM]]

p=1 to be added later today.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: rev1

Since we share the same profile now it's a good way to keep the prefs synced together with the profile name and not with all profiles.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8339625 [details] [diff] [review]
rev1

Are there any chars that might show up in a 'profileService.selectedProfile.name' that would break registry access? Wondering if we need to do any filtering here.

Comment 5

[Brian R. Bondy [:bbondy]]

I think we're OK here, the path is already used for a filename, and registry can accept anything except a backslash char.

<msdn>
Each key has a name consisting of one or more printable characters. Key names are not case sensitive. Key names cannot include the backslash character (\), but any other printable character can be used. Value names and data can include the backslash character.
<source>http://msdn.microsoft.com/en-us/library/ms724946%28VS.85%29.aspx</source>
</msdn>

Comment 6

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/fx-team/rev/efd16375788e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efd16375788e