Closed Bug 940985 Opened 6 years ago Closed 6 years ago

Win7 glass: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: fx4waldi, Assigned: fx4waldi)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P3])

Attachments

(3 files, 1 obsolete file)

Attached image bug
Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar
Status: UNCONFIRMED → NEW
Component: Toolbars and Customization → Theme
Ever confirmed: true
Attached image after patch
Attached patch 20112013_patch.diff (obsolete) — Splinter Review
Summary: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar → Win7 glass: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar
Comment on attachment 8335266 [details] [diff] [review]
20112013_patch.diff

Review of attachment 8335266 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Instead of duplicating all these rules for first the edit controls, and then the zoom, can you make them of the form:

%define nested-buttons #zoom-out-button, #zoom-in-button, #cut-button, #copy-button, #paste-button

... > toolbaritem > :-moz-any(@nested-buttons@)

to reduce the number of selectors and their length? With that, I'd r+ this!

If you're doing this based on your actual nightly rather than a source tree and need me to change the patch for you, just let me know.

PS: for 'credit' / commit message, is there a real name you want me to use to go with the email address, or should I commit with name 'fx4waldi@yahoo.com' ?
Attachment #8335266 - Flags: feedback+
I use latest UX code. 
You commit without real name.
Attachment #8335266 - Attachment is obsolete: true
Attachment #8335289 - Flags: review?(gijskruitbosch+bugs)
Attachment #8335289 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → fx4waldi
I'll check this in right now, but it needs to have [Australis] in the commit message so we back it out on holly, so I'll do it myself. Sorry for forgetting this yesterday.
Status: NEW → ASSIGNED
Keywords: checkin-needed
remote:   https://hg.mozilla.org/integration/fx-team/rev/721c8a7f0466
Whiteboard: [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/721c8a7f0466
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.