Closed
Bug 940985
Opened 12 years ago
Closed 12 years ago
Win7 glass: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: fx4waldi, Assigned: fx4waldi)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [Australis:P3])
Attachments
(3 files, 1 obsolete file)
bug
Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar
|
||
Updated•12 years ago
|
Blocks: australis-merge, australis-cust
Status: UNCONFIRMED → NEW
Component: Toolbars and Customization → Theme
Ever confirmed: true
|
|
||
Updated•12 years ago
|
Summary: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar → Win7 glass: Cut/Copy/Paste and zoom control are not inverted on tab bar and menu bar
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8335266 [details] [diff] [review]
20112013_patch.diff
Review of attachment 8335266 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! Instead of duplicating all these rules for first the edit controls, and then the zoom, can you make them of the form:
%define nested-buttons #zoom-out-button, #zoom-in-button, #cut-button, #copy-button, #paste-button
... > toolbaritem > :-moz-any(@nested-buttons@)
to reduce the number of selectors and their length? With that, I'd r+ this!
If you're doing this based on your actual nightly rather than a source tree and need me to change the patch for you, just let me know.
PS: for 'credit' / commit message, is there a real name you want me to use to go with the email address, or should I commit with name 'fx4waldi@yahoo.com' ?
Attachment #8335266 -
Flags: feedback+
I use latest UX code.
You commit without real name.
Attachment #8335266 -
Attachment is obsolete: true
Attachment #8335289 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Updated•12 years ago
|
Attachment #8335289 -
Flags: review?(gijskruitbosch+bugs) → review+
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
||
Updated•12 years ago
|
Assignee: nobody → fx4waldi
|
|
||
Comment 5•12 years ago
|
||
I'll check this in right now, but it needs to have [Australis] in the commit message so we back it out on holly, so I'll do it myself. Sorry for forgetting this yesterday.
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
|
||
Comment 6•12 years ago
|
||
Whiteboard: [Australis:P3][fixed-in-fx-team]
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•