941009 - [meta] Move Places integration from DownloadIntegration to DownloadHistory.jsm

Status: NEW

(Toolkit :: Downloads API, task, P3)

Description

[:Paolo Amadini]

The portions of the DownloadIntegration module that interact with Places should be moved to a separate Desktop-specific module, integrated using the system from bug 899013.

Comment 1

[Marco Bonardo [:mak]]

nsIDownloadHistory had been created for the purposes of integrating downloads with any underlying history implementation

Comment 2

[:Paolo Amadini]

The purpose here is to separate the code that is unused in products other than Desktop, including history observers, for which #ifdefs have been introduced now in B2G. This could be more likely a Desktop-specific module containing some Places integration code, rather than a Places-specific module, though we'll see what works best when we get there.

Comment 3

[:Paolo Amadini]

The new DownloadHistory.jsm module can be the main interface for all the interactions between Download objects and history. It depends on Places and provides Downloads API views on the data.

I don't know if going forward the nsIDownloadHistory interface should still exist separately. Even if DownloadHistory.jsm could end up depending on how the actual data is stored in Places, another level of indirection is probably unneeded.