941024 - Add a timeout to ensureFullRepaint since screenshoots can take forever

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: full.repaint.timeout.patch

Alive,
you were right that we need a timeout for screenshoots in bug 926535 since i can see that they sometimes takes forever to arrive and it makes the UI feels unresponsive and unreliable.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8335320 [details] [diff] [review]
full.repaint.timeout.patch

Review of attachment 8335320 [details] [diff] [review]:
-----------------------------------------------------------------

I like you do what I said.

::: apps/system/js/window.js
@@ +341,2 @@
>        var request = iframe.getScreenshot(1, 1);
>        request.onsuccess = request.onerror = function onRepainted() {

You should have a flag here to know if the callback is already called in your timer. Otherwise callback would be called twice. See
https://github.com/alivedise/gaia/blob/bugzilla/907013_master_rebasing/app_window_manager_v3/apps/system/js/window.js#L1000

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/473954333fa1ccc98d93e72f7038df9fa17abdab