Make findbar/zoom text selection smarter about scroll positioning

RESOLVED INVALID

Status

RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: jimm, Unassigned)

Tracking

Trunk
x86_64
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Currently we position scroll using an x coordinate that's at the center of the selected text. This can result in selection that is clipped by the viewport.

We do a pretty good job of positioning along the y axis, but a rotten job of positioning along x. We should improve this to better center selected text when we have scroll area to leverage.
Blocks: 838081
Whiteboard: [triage]
(Reporter)

Comment 1

5 years ago
We should also look at our zoom to rect code in content. I think we'll end up using this in the findbar code as well.

If we want to block on this is should be release28.
Summary: Make findbar text selection smarter about scroll positioning → Make findbar/zoom text selection smarter about scroll positioning
(Reporter)

Comment 2

5 years ago
This was fixed partially by another landing- we no longer set the x coord to the middle of the selection. However we still don't center well. I think this will get fixed by bug 940952 when we get to it.
No longer blocks: 838081
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Whiteboard: [triage]
You need to log in before you can comment on or make changes to this bug.