Closed Bug 941083 Opened 10 years ago Closed 10 years ago

CustomizableUI.createWidget should invalidate widget wrappers

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P1])

Attachments

(1 file)

invalidate widget wrappers on createWidget calls,
4.08 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
This is blocking correct fixes for bug 940820.
Added a test, too.
Attachment #8335391 - Flags: review?(mconley)
Comment on attachment 8335391 [details] [diff] [review]
invalidate widget wrappers on createWidget calls,

Review of attachment 8335391 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine - I just think we need to include this bug number in the test filename.

::: browser/components/customizableui/test/browser.ini
@@ +35,5 @@
>  # Because this test is about the menubar, it can't be run on mac
>  skip-if = os == "mac"
>  
>  [browser_panel_toggle.js]
> +[browser_invalidate_wrapper_cache_createWidget.js]

This test filename should include the bug number, I think.
Attachment #8335391 - Flags: review?(mconley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/97ae1ad323b7

with a bug number in the filename.
Status: NEW → ASSIGNED
Whiteboard: [Australis:P1] → [Australis:P1][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/97ae1ad323b7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.