Closed
Bug 941083
Opened 12 years ago
Closed 12 years ago
CustomizableUI.createWidget should invalidate widget wrappers
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P1])
Attachments
(1 file)
|
4.08 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
This is blocking correct fixes for bug 940820.
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8335391 [details] [diff] [review]
invalidate widget wrappers on createWidget calls,
Review of attachment 8335391 [details] [diff] [review]:
-----------------------------------------------------------------
This looks fine - I just think we need to include this bug number in the test filename.
::: browser/components/customizableui/test/browser.ini
@@ +35,5 @@
> # Because this test is about the menubar, it can't be run on mac
> skip-if = os == "mac"
>
> [browser_panel_toggle.js]
> +[browser_invalidate_wrapper_cache_createWidget.js]
This test filename should include the bug number, I think.
Attachment #8335391 -
Flags: review?(mconley) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/97ae1ad323b7
with a bug number in the filename.
Status: NEW → ASSIGNED
Whiteboard: [Australis:P1] → [Australis:P1][fixed-in-fx-team]
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•