941085 - File uploads support

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

Attachment: test_file_upload.py

Marionette lacks support for file uploads.  WebDriver uses sendKeys on
<input type=file> elements to set the value to the absolute path of
the file.

When using WebDriver remotely over the wire an additional end-point,
POST /file, is used to temporarily store the file on the remote server
until sendKeys is called a second time, upon which the absolute path
should refer to the remote file instead of the local file.

The resolution from our F2F in Boston was to follow the logic that
sendKeys, by default, appends as it would textual elements.  Provided
the user agent supports the concept of multiple, calling it a second
time would append another file.  If the user agent doesn't understand
this concept, it will replace the set file.

The discussion around the resolution can be found here:

    http://www.w3.org/2013/06/13-testing-minutes.html#item08

See also the spec bug about covering this in the algorithm for sendKeys:

    https://www.w3.org/Bugs/Public/show_bug.cgi?id=23876

See the attached TC for a few tests, which can be executed using
`python runtests.py --binary=/path/to/firefox --type=browser
~/test_file_upload.py`.

Comment 1

[Andreas Tolfsen ❲:ato❳]

hsteen experimented with this using special powers last night, and was able to come up with a solution:

<hallvors> yay. m.set_context(m.CONTEXT_CHROME) followed by m.execute_script('gBrowser.contentDocument.getElementById("input_type_file_id").value="file.txt" WORKS! I can upload files!

Comment 2

[Hallvord R. M. Steen [:hallvors]]

(AFAIK this won't work on Android though - the extension API is different.. In any case using send_keys or a dedicated API should be supported :))

Comment 3

[Andreas Tolfsen ❲:ato❳]

It also won't work in a B2G context, but leaving Android and B2G as unsupported for the time being should be fine according to :automatedtester.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Have a working patch locally.  Need to add tests for uploading to local httpd.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: bz://941085/ato

/r/6359 - Bug 941085: File uploads support in Marionette

Pull down this commit:

hg pull review -r 810d78270512243b91f0e93a199907e9cbeaf406

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8586157 [details]
MozReview Request: bz://941085/ato

/r/6359 - Bug 941085: File uploads support in Marionette

Pull down this commit:

hg pull review -r 9c53900e6c7d8ba99f2d256dd2f054a346b011d5

Comment 7

[Andreas Tolfsen ❲:ato❳]

try based off inbound: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f44c8e2f18

Comment 8

[David Burns :automatedtester]

Comment on attachment 8586157 [details]
MozReview Request: bz://941085/ato

https://reviewboard.mozilla.org/r/6357/#review5323

::: testing/marionette/driver.js
(Diff revision 2)
> +          let f;

variable name to `file`

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8586157 [details]
MozReview Request: bz://941085/ato

/r/6359 - Bug 941085: File uploads support in Marionette

Pull down this commit:

hg pull -r 73ab0d4b4ca088eca38ad8ff49286b97dff76b8c https://reviewboard-hg.mozilla.org/gecko/

Comment 10

[Andreas Tolfsen ❲:ato❳]

New try run, fixes sendKeysToElement for non-file input elements:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=5583d4255b66

Comment 11

[David Burns :automatedtester]

Try is not happy, will review after next try run

Comment 12

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8586157 [details]
MozReview Request: bz://941085/ato

/r/6359 - Bug 941085: File uploads support in Marionette

Pull down this commit:

hg pull -r 81ffce46bc24c3eb0485d42b4b27d5af262159cc https://reviewboard-hg.mozilla.org/gecko/

Comment 13

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c439f6389346

Comment 14

[Andreas Tolfsen ❲:ato❳]

Filed bug 1149998 since we seem unable to use HTMLElement#mozSetFileArray on CPOW-wrapped elements passed from a remote content process.

Comment 15

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8586157 [details]
MozReview Request: bz://941085/ato

/r/6359 - Bug 941085: File uploads support in Marionette

Pull down this commit:

hg pull -r 906d7b65c4bc4315fe0d93284e5ecdebb054130b https://reviewboard-hg.mozilla.org/gecko/

Comment 16

[Andreas Tolfsen ❲:ato❳]

new try run with test fixes for upload test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf04b863f74f

Comment 17

[David Burns :automatedtester]

Windows failure :(

Comment 18

[Andreas Tolfsen ❲:ato❳]

Disabled failing test on Windows due to http://bugs.python.org/issue14574 and filed bug 1150512 about moving to wptserve.

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/93166201fca0

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Backed out for widespread Gip timeouts.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ada788536540

Comment 20

[Andreas Tolfsen ❲:ato❳]

Fixed test failures and pushed to inbound again:  https://hg.mozilla.org/integration/mozilla-inbound/rev/f3a27b508519

The cause of the failures was that GaiaTestRunner relied on internal state set in BaseMarionetteTestRunner (self.httpd) and modified this.  This patch changed BaseMarionetteTestRunner.start_httpd to create_httpd which instead returned the httpd which the constructor assigned to self.httpd.

This was a problem for GaiaTestRunner because it is overriding start_httpd.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Backed out for Mn-e10s failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/88061a523064

https://treeherder.mozilla.org/logviewer.html#?job_id=8675124&repo=mozilla-inbound

Comment 22

[Andreas Tolfsen ❲:ato❳]

Either e10s isn't being entirely truthful to us about its load events, or WebElement.click is doing something very wrong.  I added another explicit wait for the URL to change after the submit element is clicked.

I didn't see the problem rerunning the tests on e10s locally 40 times.

Pushed to inbound again: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea71f4c74e6

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ea71f4c74e6

Comment 25

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 941085: File uploads support in Marionette