941089 - Remove __noSuchMethod__ from scratchpad/test/browser_scratchpad_ui.js

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P3)

Description

[Brandon Benvie [:benvie]]

We're trying to remove __noSuchMethod__ usage from the tree, so its usage in this test should be removed.

Comment 1

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug941089.patch

Comment 2

[Brandon Benvie [:benvie]]

Comment on attachment 8335780 [details] [diff] [review]
bug941089.patch

Review of attachment 8335780 [details] [diff] [review]:
-----------------------------------------------------------------

This won't work. This removes the usage of __noSuchMethod__, but it doesn't replace it with anything. You need to replace the method being tested with a mock method or something to register that the menu item successfully worked.

Comment 3

[Peiyong Lin[:lpy](UTC+8)]

Hello benvie, what do you mean of mock method?

Comment 4

[Brandon Benvie [:benvie]]

You need to replace the code

> delete sp[methodName];

with something like

> sp[methodName] = () => {
>   lastMethodCalled = true;
> };

When menu.doCommand() is run it's going to attempt to call the scratchpad method. You need to make sure that has happened.

Comment 5

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug941089.patch

V2

Comment 6

[Brandon Benvie [:benvie]]

Comment on attachment 8336544 [details] [diff] [review]
bug941089.patch

Review of attachment 8336544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 7

[Brandon Benvie [:benvie]]

You'll need to rebase this patch because another change to this test landed in the last few days.

Comment 8

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug941089.patch

final version

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1db8ba166b60

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1db8ba166b60