Closed Bug 941144 Opened 6 years ago Closed 6 years ago

getWindows not matching Selenium command getCurrentWindowHandles

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox28 fixed, firefox29 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: ato, Assigned: ato)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Marionette uses "getWindows" getting a list of the open windows'
handles while the expected webdriver command is
"getCurrentWindowHandles".

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.
Blocks: 962181
No longer blocks: webdriver
Summary: getWindows not matching webdriver command getCurrentWindowHandles → getWindows not matching Selenium command getCurrentWindowHandles
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8364493 [details] [diff] [review]
0001-Bug-941144-getWindows-not-matching-Selenium-command.patch

Review of attachment 8364493 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +1199,2 @@
>      this.command_id = this.getCommandId();
> +    let rv = [];

Why the change in variable name?
Attachment #8364493 - Flags: review?(dburns) → review+
Oops, corrected.  Attached updated patch for which I've carried on the r+.
Attachment #8364493 - Attachment is obsolete: true
Attachment #8365026 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a53cbf955a90
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.