941144 - getWindows not matching Selenium command getCurrentWindowHandles

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette uses "getWindows" getting a list of the open windows'
handles while the expected webdriver command is
"getCurrentWindowHandles".

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941144-getWindows-not-matching-Selenium-command.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=8f78315a4d84

Comment 2

[David Burns :automatedtester]

Comment on attachment 8364493 [details] [diff] [review]
0001-Bug-941144-getWindows-not-matching-Selenium-command.patch

Review of attachment 8364493 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +1199,2 @@
>      this.command_id = this.getCommandId();
> +    let rv = [];

Why the change in variable name?

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941144-getWindows-not-matching-Selenium-command.patch

Oops, corrected.  Attached updated patch for which I've carried on the r+.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a53cbf955a90

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a53cbf955a90

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/286d29768633