941148 - screenShot not matching webdriver command takeScreenshot

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette uses "screenShot" (camel case) for taking a screenshot of
the current browser window while the expected webdriver command is
"screenshot" (lower case).

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.

Comment 1

[Andreas Tolfsen ❲:ato❳]

The spec is saying the command end-point should be "DOMString
takeScreenshot(optional WebElement el)".  Updated title to reflect
that.

To preserve Selenium compatibility we will still need "screenshot",
however.  Filed tracking bug 962181 and bug 962182 specifically about
this command.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941148-Rename-screenShot-to-takeScreenshot-for-w.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=82fdc39165ba

Comment 3

[David Burns :automatedtester]

Comment on attachment 8364342 [details] [diff] [review]
0001-Bug-941148-Rename-screenShot-to-takeScreenshot-for-w.patch

Review of attachment 8364342 [details] [diff] [review]:
-----------------------------------------------------------------

r+ can be carried through after nit corrected

::: testing/marionette/marionette-listener.js
@@ +2133,5 @@
>  
> +  // Return the Base64 String back to the client bindings and they can
> +  // manage saving the file to disk if it is required
> +  var dataUrl = canvas.toDataURL("image/png","");
> +    var data = dataUrl.substring(dataUrl.indexOf(",") + 1);

line up with rest of the code

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941148-Rename-screenShot-to-takeScreenshot-for-w.patch

Fixed issues, carrying on r+ from dburns.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95016fa7e7a0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95016fa7e7a0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3ee86043f87f