Closed Bug 941148 Opened 6 years ago Closed 6 years ago

screenShot not matching webdriver command takeScreenshot

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox28 fixed, firefox29 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

Marionette uses "screenShot" (camel case) for taking a screenshot of
the current browser window while the expected webdriver command is
"screenshot" (lower case).

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Summary: "screenShot" not matching webdriver command "screenshot" → screenShot not matching webdriver command takeScreenshot
The spec is saying the command end-point should be "DOMString
takeScreenshot(optional WebElement el)".  Updated title to reflect
that.

To preserve Selenium compatibility we will still need "screenshot",
however.  Filed tracking bug 962181 and bug 962182 specifically about
this command.
Comment on attachment 8364342 [details] [diff] [review]
0001-Bug-941148-Rename-screenShot-to-takeScreenshot-for-w.patch

Review of attachment 8364342 [details] [diff] [review]:
-----------------------------------------------------------------

r+ can be carried through after nit corrected

::: testing/marionette/marionette-listener.js
@@ +2133,5 @@
>  
> +  // Return the Base64 String back to the client bindings and they can
> +  // manage saving the file to disk if it is required
> +  var dataUrl = canvas.toDataURL("image/png","");
> +    var data = dataUrl.substring(dataUrl.indexOf(",") + 1);

line up with rest of the code
Attachment #8364342 - Flags: review?(dburns) → review+
Fixed issues, carrying on r+ from dburns.
Attachment #8364342 - Attachment is obsolete: true
Attachment #8365032 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/95016fa7e7a0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
You need to log in before you can comment on or make changes to this bug.