Closed
Bug 941189
Opened 12 years ago
Closed 12 years ago
change servo builder to use backup/restore targets in separate makefile
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jack, Assigned: bhearsum)
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
mozilla
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Recently we've been doing some Makefile hacking and managed to break the build slaves many times. This is because we run backup-rust and restore-rust using the old Makefile but with a fresh checkout of a different branch. This causes problems if the makefile includes things that don't exist on the current branch.
I've created a new Makefile.backup that has these targets in it and won't have version skew. buildbot will need to be modified to do:
make -f $SRC/Makefile.backup backup-rust
and
make -f $SRC/Makefile.backup restore-rust
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8336140 -
Flags: review?(aki)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → bhearsum
|
||
Updated•12 years ago
|
Attachment #8336140 -
Flags: review?(aki) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8336140 [details] [diff] [review]
use Makefile.backup
This will probably get merged to production on Monday.
Attachment #8336140 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•12 years ago
|
||
In production - should apply to all builds started from now onwards.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 4•12 years ago
|
||
something[s] here made it to production
|
|
Assignee | |
Comment 5•12 years ago
|
||
Needed a bustage fix for this: https://hg.mozilla.org/build/mozharness/rev/96e496f3241f
|
||
Comment 6•12 years ago
|
||
in production
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•