change servo builder to use backup/restore targets in separate makefile

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jack, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Recently we've been doing some Makefile hacking and managed to break the build slaves many times. This is because we run backup-rust and restore-rust using the old Makefile but with a fresh checkout of a different branch. This causes problems if the makefile includes things that don't exist on the current branch.

I've created a new Makefile.backup that has these targets in it and won't have version skew. buildbot will need to be modified to do:

make -f $SRC/Makefile.backup backup-rust

and

make -f $SRC/Makefile.backup restore-rust
(Assignee)

Comment 1

4 years ago
Created attachment 8336140 [details] [diff] [review]
use Makefile.backup
Attachment #8336140 - Flags: review?(aki)
(Assignee)

Updated

4 years ago
Assignee: nobody → bhearsum

Updated

4 years ago
Attachment #8336140 - Flags: review?(aki) → review+
(Assignee)

Comment 2

4 years ago
Comment on attachment 8336140 [details] [diff] [review]
use Makefile.backup

This will probably get merged to production on Monday.
Attachment #8336140 - Flags: checked-in+
(Assignee)

Comment 3

4 years ago
In production - should apply to all builds started from now onwards.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
something[s] here made it to production
(Assignee)

Comment 5

4 years ago
Needed a bustage fix for this: https://hg.mozilla.org/build/mozharness/rev/96e496f3241f
in production
You need to log in before you can comment on or make changes to this bug.