941211 - Customize palette looks bad with bigger GTK font size: text under tools does not fit, bottom parts are hidden

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[[:Aleksej]]

Attachment: australis-customize-palette-bigger-gtk-font.png

My font size for GTK apps is 16-18.

In 2013-11-20-03-02-02-mozilla-central-firefox-28.0a1.en-US.linux-x86_64's customize mode ("Customize and Control Nightly" → "Customize"), the palette's icon captions do not cope with that, see screenshot.

Comment 1

[[:Aleksej]]

With font size 17 and above, the captions are not visible at all.

Comment 2

[[:Aleksej]]

The palette also has a severe min-width, apparently based on the "More Tools to Add to the Menu and Toolbar" text.  With font size 18 and the window size Nightly chooses at start, the "Customize and Control Nightly" button does not fit the window.

Comment 3

[Justin Dolske [:Dolske]]

We probably shouldn't use the system font size for the icon labels.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Justin Dolske [:Dolske] from comment #3)
> We probably shouldn't use the system font size for the icon labels.

This doesn't seem right. Why does stuff get cut off vertically in the first place?

Comment 5

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Justin Dolske [:Dolske] from comment #3)
> > We probably shouldn't use the system font size for the icon labels.
> 
> This doesn't seem right. Why does stuff get cut off vertically in the first
> place?

Because of:

http://hg.mozilla.org/mozilla-central/annotate/f99c42bb080e/browser/base/content/browser.css#l939

We could make this a calc expression of a fixed pixel value for the icon/widget representation, plus an em value for the text? It should ideally stay the same for all the items, just like in the menu panel, in order for the drag animation code to work correctly...

Comment 6

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Justin Dolske [:Dolske] from comment #3)
> > We probably shouldn't use the system font size for the icon labels.
> 
> This doesn't seem right. Why does stuff get cut off vertically in the first
> place?

And also because the icons in the menupanel and palette are sized in em, which will depend on OS font size. We should stop doing that. I'll try and come up with a comprehensive patch.

Comment 7

[:Gijs (he/him)]

Attachment: use px sizes for Australis' panel/palette icons, and incorporate into height,

So I made this on OS X. Now icons actually use 32px instead of 29, and look much better, too. I've basically switched us to use px for icons, em for widths, and a combination for height (to incorporate the height of the icon and that of the text, the latter of which might change depending on system font size). Generally, this seems to work excellently, although of course things will start going pear-shaped if you have such a small font setting that 7em is smaller than the icon and its margin (40px, so a font-size of less than 6px). I think we can live with that. I'll doublecheck this solves the GTK issue in a bit and then request review.

Comment 8

[:Gijs (he/him)]

Attachment: use px sizes for Australis' panel/palette icons, and incorporate into height,

I tweaked the height of these items, because they are far clumsier than they need to be at the moment, and verified that this fixes the GTK issue. Jared, what do you think?

Comment 9

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/8bf0fa0fa609

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8bf0fa0fa609

Comment 11

[Paul Silaghi, QA [:pauly]]

(In reply to [:Aleksej] from comment #0)
> My font size for GTK apps is 16-18.
Aleksej, could you please verify this?

Comment 12

[[:Aleksej]]

Verified that the icons are not huge in 2014-01-22-03-05-21-mozilla-central-firefox-29.0a1.en-US.linux-x86_64.

Comment 13

[Paul Silaghi, QA [:pauly]]

ty