941226 - [Australis] Subscribe button looks disabled even in pages with feeds, when first added to the panel menu

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Elad Alfassa]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131120062258

Steps to reproduce:

Go to gmail, which has a feed.
open the Australis menu.



Actual results:

Subscribe button appears disabled, but clicking on it does bring you to the subscription page


Expected results:

It should look enabled in pages with feeds.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Elad, can you check to see if the button has disabled="false" set on it?

Comment 2

[Elad Alfassa]

Oddly enough, I can't reproduce this bug again. I'll close it for now.

Comment 3

[:Gijs (he/him)]

(In reply to Elad Alfassa from comment #2)
> Oddly enough, I can't reproduce this bug again. I'll close it for now.

I suspect I have STR:

1. Close Nightly.
2. Open Nightly. Don't open the menu.
3. Go to gmail.
4. Once gmail has fully loaded, open the menu.

Does that make this problem reappear?

Comment 4

[Elad Alfassa]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Elad Alfassa from comment #2)
> > Oddly enough, I can't reproduce this bug again. I'll close it for now.
> 
> I suspect I have STR:
> 
> 1. Close Nightly.
> 2. Open Nightly. Don't open the menu.
> 3. Go to gmail.
> 4. Once gmail has fully loaded, open the menu.
> 
> Does that make this problem reappear?

Nope.

Comment 5

[:Gijs (he/him)]

(In reply to Elad Alfassa from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > (In reply to Elad Alfassa from comment #2)
> > > Oddly enough, I can't reproduce this bug again. I'll close it for now.
> > 
> > I suspect I have STR:
> > 
> > 1. Close Nightly.
> > 2. Open Nightly. Don't open the menu.
> > 3. Go to gmail.
> > 4. Once gmail has fully loaded, open the menu.
> > 
> > Does that make this problem reappear?
> 
> Nope.

Huh, then I don't know. Thanks for checking, and please do reopen if you find STR / see this again. :-)

Comment 6

[Matt Brubeck (:mbrubeck)]

I can reproduce this reliably.  It happens after first adding the Subscribe button to the toolbar or overflow menu, but stops after Firefox is restarted.  Steps to reproduce:

1) Make sure the Subscribe button is not in the toolbar or overflow panel.
2) Enter customization mode, and add the Subscribe button to the toolbar or panel.
3) Navigate to a page with a feed link.

Expected results: Subscribe button is enabled.
Actual results: Subscribe button appears disabled, though clicking on it works anyway.

Comment 7

[:Gijs (he/him)]

Yay for STR! I'll investigate on Monday. Setting needinfo so I don't forget.

Comment 8

[Matt Brubeck (:mbrubeck)]

(In reply to Jared Wein [:jaws] from comment #1)
> Elad, can you check to see if the button has disabled="false" set on it?

document.getElementById("feed-button").getAttribute("disabled") in the browser console prints "true".

Comment 9

[:Gijs (he/him)]

(In reply to Matt Brubeck (:mbrubeck) from comment #6)
> I can reproduce this reliably.  It happens after first adding the Subscribe
> button to the toolbar or overflow menu, but stops after Firefox is
> restarted.  Steps to reproduce:
> 
> 1) Make sure the Subscribe button is not in the toolbar or overflow panel.
> 2) Enter customization mode, and add the Subscribe button to the toolbar or
> panel.
> 3) Navigate to a page with a feed link.
> 
> Expected results: Subscribe button is enabled.
> Actual results: Subscribe button appears disabled, though clicking on it
> works anyway.

Alright, I'm trying this on Win7, because I don't have a copy of Win8.1 and don't understand how that could influence the bug, but I'm not having any luck reproducing. Here's my exact steps (on a clean profile):

1. Start Firefox. The button is in the palette (not the menupanel, not the toolbar - the customization palette).
2. Open http://edition.cnn.com/ in a new tab. This has a feed.
3. Open Customize Mode in a new tab.
4. Drag the feed button to the navbar, right after the search field.
5. Click the open CNN tab.

For me, when I execute step 5 the feed button becomes enabled.

What am I missing?

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to :Gijs Kruitbosch from comment #9)
> 4. Drag the feed button to the navbar, right after the search field.
> 5. Click the open CNN tab.
> 
> For me, when I execute step 5 the feed button becomes enabled.

The bug occurs for me if I drag the button to the menupanel instead of the navbar, in step 4.  (However, the bug continues if I then re-enter customization mode and drag it from the menupanel to the navbar.  This must be why I thought I'd tested both menu and navbar previously.)

Comment 11

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #8)
> document.getElementById("feed-button").getAttribute("disabled") in the
> browser console prints "true".

Curiously, button.getAttribute("disabled") === "true", but button.disabled === false, and button.style.MozBinding == "".

It looks like this button lost its XBL binding, or was never bound in the first place.  updateFeeds is called at the correct time, but when it sets .disabled it just adds an expando property instead of using the XUL property setter.

Comment 12

[:Gijs (he/him)]

Attachment: feed button disabled when in Australis menu panel,

This is another one of those issues caused by XBL binding madness. Setting the (expando, at that point) when the binding isn't attached breaks it. We had similar problems with e.g. the help button in bug 910851. Just using the attribute will fix it.

Comment 13

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #12)
> Setting the (expando, at that point) when the binding isn't attached breaks it.

Should be:

> Setting the (expando, at that point) property when the binding isn't attached breaks it.


See also comment #11

Comment 14

[Mike de Boer [:mikedeboer]]

Comment on attachment 8339295 [details] [diff] [review]
feed button disabled when in Australis menu panel,

Review of attachment 8339295 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 15

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/a92a5ed04e6a

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a92a5ed04e6a