Closed
Bug 941333
Opened 11 years ago
Closed 11 years ago
Annotate SMIL GenericValueParser class / subclasses as MOZ_STACK_CLASS
Categories
(Core :: SVG, defect, P4)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: dholbert, Assigned: longsonr)
References
Details
(Whiteboard: [qa-])
nsSMILParserUtils::GenericValueParser and its subclasses should be declared as NS_STACK_CLASS, because they contain raw pointers to other objects which are either stack-allocated or at least not refcounted (because they're assumed to outlive the GenericValueParser).
So, we might as label these classes as NS_STACK_CLASS to catch bugs where someone might accidentally declare an instance in such a way that it could easily outlive some of its member-data.
Marking this as depending on bug 937614 because I don't want to bitrot longsonr's patch there. (but Robert, if you happen to want to fix this as part of bug 937614, feel free.)
|
Assignee | |
Updated•11 years ago
|
Summary: Annotate SMIL GenericValueParser class / subclasses as NS_STACK_CLASS → Annotate SMIL GenericValueParser class / subclasses as MOZ_STACK_CLASS
|
|
Assignee | |
Comment 1•11 years ago
|
||
Folded this into bug 937614
|
|
Assignee | |
Comment 2•11 years ago
|
||
Fixed by checkin for bug 937614
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → longsonr
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•