nsSMILParserUtils::GenericValueParser and its subclasses should be declared as NS_STACK_CLASS, because they contain raw pointers to other objects which are either stack-allocated or at least not refcounted (because they're assumed to outlive the GenericValueParser). So, we might as label these classes as NS_STACK_CLASS to catch bugs where someone might accidentally declare an instance in such a way that it could easily outlive some of its member-data. Marking this as depending on bug 937614 because I don't want to bitrot longsonr's patch there. (but Robert, if you happen to want to fix this as part of bug 937614, feel free.)
Summary: Annotate SMIL GenericValueParser class / subclasses as NS_STACK_CLASS → Annotate SMIL GenericValueParser class / subclasses as MOZ_STACK_CLASS
Folded this into bug 937614
Fixed by checkin for bug 937614
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.