941582 - Update test_gallery_crop_photo.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

In this test the newly cropped image now appears to be placed after the original image(2nd) rather than in front.. ie the sort order has changed.

Comment 1

[Zac C (:zac)]

This is weird, it seems a bit intermittent.
I'm a bit concerned but I have found a place to put a better wait in and I will submit that.

Comment 2

[Zac C (:zac)]

Attachment: github pr

Comment 3

[[:AndreiH]]

Comment on attachment 8336035 [details] [review]
github pr

LGTM this wait strengthens the test

Comment 4

[[:AndreiH]]

https://github.com/mozilla-b2g/gaia/commit/32225818e9a320c0232fab01fc64c0c58d3b3db3

This is not needed in v1.2, so marking it as Resolved

Comment 5

[Bob Silverberg [:bsilverberg]]

Actually, this is a test improvement, so it should be uplifted to v1.2.  Andrei, please do not be so quick to announce that patches are not needed for v1.2. This is the second one I found in my audit that actually _should_ be uplifted to v1.2.

Comment 6

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14098

Pointer to Github pull-request

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339019 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14098

Uplift to v1.2

Comment 8

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8339019 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14098

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/b912587932001da401a3fa830885080e56f8bde2