Closed Bug 941643 Opened 6 years ago Closed 6 years ago

Use menlo and consolas

Categories

(DevTools :: General, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
Attachment #8336098 - Flags: review?(bgrinstead)
Comment on attachment 8336098 [details] [diff] [review]
v1

Review of attachment 8336098 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great.  As discussed with Darrin, we should use normal instead of 1.2 on line height.  r+ with that update.

::: browser/devtools/sourceeditor/editor.js
@@ +56,5 @@
>    "  <head>" +
>    "    <style>" +
>    "      html, body { height: 100%; }" +
>    "      body { margin: 0; overflow: hidden; }" +
> +  "      .CodeMirror { width: 100%; height: 100% !important; line-height: 1.2!important}" +

Use 'normal' instead of 1.2 on line-height here
Attachment #8336098 - Flags: review?(bgrinstead) → review+
Attached patch v2Splinter Review
1.2 -> normal
Attachment #8336098 - Attachment is obsolete: true
Attachment #8336117 - Flags: review?(bgrinstead)
Attachment #8336117 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1482977302fd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
At least on OS X, the text is really big now, about twice the size it used to be, and somewhat disproportionate from the rest of the toolbox. Can't we make it smaller, or more in equilibrium with the rest of the toolbox?
Flags: needinfo?(paul)
(In reply to Victor Porof [:vp] from comment #6)
> At least on OS X, the text is really big now, about twice the size it used
> to be, and somewhat disproportionate from the rest of the toolbox. Can't we
> make it smaller, or more in equilibrium with the rest of the toolbox?

Addressed: bug 942115
Flags: needinfo?(paul)
View source still has old monospace font. Can you tell me where is located the view source code styling ? I looked in viewsource.css but I couldn't find it. I could fix this as one of my first bugs.
Flags: needinfo?(paul)
(In reply to Tim Nguyen [:ntim] from comment #9)
> View source still has old monospace font. Can you tell me where is located
> the view source code styling ? I looked in viewsource.css but I couldn't
> find it. I could fix this as one of my first bugs.

View source is not based on the devtools theme yet. It's not a thing we can do yet.
Flags: needinfo?(paul)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.