Closed
Bug 941643
Opened 11 years ago
Closed 11 years ago
Use menlo and consolas
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.98 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8336098 -
Flags: review?(bgrinstead)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8336098 [details] [diff] [review]
v1
Review of attachment 8336098 [details] [diff] [review]:
-----------------------------------------------------------------
This looks great. As discussed with Darrin, we should use normal instead of 1.2 on line height. r+ with that update.
::: browser/devtools/sourceeditor/editor.js
@@ +56,5 @@
> " <head>" +
> " <style>" +
> " html, body { height: 100%; }" +
> " body { margin: 0; overflow: hidden; }" +
> + " .CodeMirror { width: 100%; height: 100% !important; line-height: 1.2!important}" +
Use 'normal' instead of 1.2 on line-height here
Attachment #8336098 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
1.2 -> normal
Attachment #8336098 -
Attachment is obsolete: true
Attachment #8336117 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8336117 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Comment 6•11 years ago
|
||
At least on OS X, the text is really big now, about twice the size it used to be, and somewhat disproportionate from the rest of the toolbox. Can't we make it smaller, or more in equilibrium with the rest of the toolbox?
Flags: needinfo?(paul)
|
|
||
Comment 7•11 years ago
|
||
Filed bug 942115.
|
|
Assignee | |
Comment 8•11 years ago
|
||
(In reply to Victor Porof [:vp] from comment #6)
> At least on OS X, the text is really big now, about twice the size it used
> to be, and somewhat disproportionate from the rest of the toolbox. Can't we
> make it smaller, or more in equilibrium with the rest of the toolbox?
Addressed: bug 942115
Flags: needinfo?(paul)
|
||
Comment 9•11 years ago
|
||
View source still has old monospace font. Can you tell me where is located the view source code styling ? I looked in viewsource.css but I couldn't find it. I could fix this as one of my first bugs.
Flags: needinfo?(paul)
|
|
Assignee | |
Comment 10•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #9)
> View source still has old monospace font. Can you tell me where is located
> the view source code styling ? I looked in viewsource.css but I couldn't
> find it. I could fix this as one of my first bugs.
View source is not based on the devtools theme yet. It's not a thing we can do yet.
Flags: needinfo?(paul)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•