Closed
Bug 941698
Opened 11 years ago
Closed 10 years ago
HTTP cache v2: add version information to cache entries
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: michal, Assigned: mayhemer)
References
Details
Attachments
(1 file, 1 obsolete file)
5.57 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Not sure this is 100% correct, also - do you correctly translate to network order before persistence somehow?
Assignee: michal.novotny → honzab.moz
Status: NEW → ASSIGNED
Attachment #8374469 -
Flags: review?(michal.novotny)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8374469 [details] [diff] [review] v1 Review of attachment 8374469 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but it needs to be updated once we land patch from #988186. ::: netwerk/cache2/CacheFileMetadata.cpp @@ +18,5 @@ > > #define kMinMetadataRead 1024 // TODO find optimal value from telemetry > #define kAlignSize 4096 > > +#define kCacheEntryVersion 2 Let's start with version 1.
Attachment #8374469 -
Flags: review?(michal.novotny) → feedback+
Reporter | ||
Comment 3•10 years ago
|
||
Attachment #8374469 -
Attachment is obsolete: true
Attachment #8402880 -
Flags: review+
Reporter | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9214ddd9ee
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0d9214ddd9ee
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•