941710 - move out text boundary calculation from GetPosAndText

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8336156 [details] [diff] [review]
patch

>+HyperTextAccessible::TextBounds(int32_t aStartOffset, int32_t aEndOffset,
>+                                uint32_t aCoordType)
>+{
>+  int32_t startOffset = ConvertMagicOffset(aStartOffset);
>+  int32_t endOffset = ConvertMagicOffset(aEndOffset);
>+
>+  int32_t childIdx = GetChildIndexAtOffset(startOffset);
>+  if (childIdx == -1)
>+    return nsIntRect();

assert startoffset == endoffset == 0?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> assert startoffset == endoffset == 0?

should we assert for more cases for example startoffset >= endoffsert? do we need to return early?

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #2)
> (In reply to Trevor Saunders (:tbsaunde) from comment #1)
> 
> > assert startoffset == endoffset == 0?
> 
> should we assert for more cases for example startoffset >= endoffsert? do we
> need to return early?

more aserts can't hurt.  As for returning early I guess it depends on if consumers are trusted to be sane.

Comment 4

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/964f8357390b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/964f8357390b