Closed Bug 941767 Opened 6 years ago Closed 6 years ago

Fix rooting hazard in GetNativeForGlobal()

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

GetNativeForGlobal() calls EnsureCompartmentPrivate() just to check if the compartment private has a scope.  This can GC if it needs to create the compartment private.

Instead, we can just call MaybeGetObjectScope() which won't attempt to create the compartment private if it's not already present.
Attachment #8336216 - Flags: review?(bobbyholley+bmo)
Attachment #8336216 - Flags: review?(bobbyholley+bmo) → review+
Component: JavaScript Engine → XPConnect
https://hg.mozilla.org/mozilla-central/rev/32aaf8cf175a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.