Closed
Bug 941767
Opened 11 years ago
Closed 11 years ago
Fix rooting hazard in GetNativeForGlobal()
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
977 bytes,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
GetNativeForGlobal() calls EnsureCompartmentPrivate() just to check if the compartment private has a scope. This can GC if it needs to create the compartment private. Instead, we can just call MaybeGetObjectScope() which won't attempt to create the compartment private if it's not already present.
Attachment #8336216 -
Flags: review?(bobbyholley+bmo)
|
||
Updated•11 years ago
|
Attachment #8336216 -
Flags: review?(bobbyholley+bmo) → review+
|
||
Updated•11 years ago
|
Component: JavaScript Engine → XPConnect
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/32aaf8cf175a
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32aaf8cf175a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•