941795 - LayerView.show/hide should be renamed to LayerView.showSurface/hideSurface

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Taylor Skidmore [:SirSkidmore]]

|18:53:36         snorp | mcomella: the LayerView (parent of the SurfaceView) remains visible                                   
│18:53:42   SirSkidmore | liuche: can do                                                                                         
│18:53:45         snorp | mcomella: and the LayerView has the touch interceptors                                                   
│18:54:52      mcomella | snorp: I see. That doesn't seem to be the expected behavior when LayerView.show/hide would be called     
│                       | then. Do you think it'd benefit from a name change?                                                    
│18:54:54        liuche | SirSkidmore: sorry about that! but definitely check back :)                                            
│18:55:17         snorp | mcomella: yeah, something like show/hideSurface is more appropriate                                      
│18:55:32         snorp | mcomella: setVisibility is already adequate for the LayerView itself                                     

LayerView.show/hide should be more descriptive on what it's actually doing.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I spoke with Taylor on IRC and he'll be taking care of this.

Comment 2

[Taylor Skidmore [:SirSkidmore]]

Attachment: Simple rename of LayerView.show/hide to LayerView.showSurface/hideSurface. r=mcomella

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8336271 [details] [diff] [review]
Simple rename of LayerView.show/hide to LayerView.showSurface/hideSurface. r=mcomella

Review of attachment 8336271 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm but snorp should definitely double-check this.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8336271 [details] [diff] [review]
Simple rename of LayerView.show/hide to LayerView.showSurface/hideSurface. r=mcomella

Review of attachment 8336271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb690f7d744

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ffb690f7d744