Closed Bug 941821 Opened 6 years ago Closed 6 years ago

Fix an exact rooting hazard false positive across ForkJoin invocation

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

ForkJoinSlice has an AutoAssertNoGC, so we are protected in practice. Unfortunately the analysis only propagates GCThingedness. As this propagation is a bit cumbersome and we want to keep the analysis simple, we think a better solution is to add a second AutoAssertNoGC, rather than adding a new analysis mechanism to propagate a second type.

I got an over-the-shoulder r+ from sfink so we can move on with the GC workweek. Niko, Shu, feel free to shout if you disagree strongly with this patch.
Attachment #8336296 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2ab7cff78c50
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.