941821 - Fix an exact rooting hazard false positive across ForkJoin invocation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: suppress_ForkJoinSlice_again-v0.diff

ForkJoinSlice has an AutoAssertNoGC, so we are protected in practice. Unfortunately the analysis only propagates GCThingedness. As this propagation is a bit cumbersome and we want to keep the analysis simple, we think a better solution is to add a second AutoAssertNoGC, rather than adding a new analysis mechanism to propagate a second type.

I got an over-the-shoulder r+ from sfink so we can move on with the GC workweek. Niko, Shu, feel free to shout if you disagree strongly with this patch.

Comment 1

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a64bdb8671ae

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c2418bf5a3fc for jit-test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=30912860&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=30912784&tree=Mozilla-Inbound

Comment 3

[Terrence Cole [:terrence]]

Relanding:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab7cff78c50

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ab7cff78c50