Apply the standard footer to State of Mozilla 2012

VERIFIED FIXED

Status

www.mozilla.org
Pages & Content
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: kohei, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1191014] , URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
State of Mozilla 2012 has been localized. I think it might be better to have a language switcher on the footer of the pages by applying the standard site footer. A pull request coming.
(Reporter)

Updated

5 years ago
Blocks: 906136
(Reporter)

Comment 1

5 years ago
Created attachment 8336371 [details] [review]
PR on GitHub
(Reporter)

Updated

5 years ago
Whiteboard: [kb=1191014]
The page was designed with the simplified alternative footer, so we should run this by John Slater and Sean Martell (both cc'd) before we just tack on the standard footer.

If we need to keep the simple footer, how hard would it be to integrate the language switcher into it, preferably without duplicating a lot of code? Is it a standalone include? 

If we can use the standard mozorg footer on this page, we could still customize it a bit with CSS (we can change the link color, at the very least).
The other reason I suggested applying the standard footer is that it also keep us from having to go back and manually update the copyright dates each year.
(Reporter)

Comment 4

5 years ago
The copyright year will be automatically updated:

> Portions of this content are ©1998-{{ current_year }}

Like /firefox/new/, the language switcher can only be added if the design is important.
Sean, are you OK with adding the standard footer?
Flags: needinfo?(smartell)
Ping? We're blocked on moving forward until we get some input from design. Is there a compelling reason to keep the custom footer, or can we just swap in the standard footer and call it a day?

Comment 7

5 years ago
Yep, standard footer is fine!
Flags: needinfo?(smartell)

Comment 8

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/255b31258b234860cb2749a04dcda886e8f1c965
Bug 941870 - Apply the standard footer to State of Mozilla 2012

https://github.com/mozilla/bedrock/commit/db67a624d9305a5cc5815a3aa9991b59a3bd63e0
Merge pull request #1429 from kyoshino/bug-941870-som12-footer

Bug 941870 - Apply the standard footer to State of Mozilla 2012
fixed on stage https://www.allizom.org/en-US/foundation/annualreport/2012/
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
on prod
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.