941889 - configure errors with android v19, cannot find dx

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[raymond [:retornam] (inactive)]

I followed the steps in
https://wiki.mozilla.org/Mobile/Fennec/Android for MacOS X and I got an error when I tried ./mach build. "dx" was not found when using the Android SDk version 19.

Comment 1

[raymond [:retornam] (inactive)]

Attachment: bug941889.patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8336386 [details] [diff] [review]
bug941889.patch

I'm sorry, I'm really not the person to review this type of change.  I did run into this issue once in another bug (maybe that's what you found), but it was fixed by a patch in that bug.

Comment 3

[Aaron Train [:aaronmt]]

New patches in original bug.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8336386 [details] [diff] [review]
bug941889.patch

Review of attachment 8336386 [details] [diff] [review]:
-----------------------------------------------------------------

Sigh.  This is tedious.

r=nalexander, bug pleese format the commit line like:

Bug 941889 - Make configure recognize Android 19 tools. r=nalexander

Comment 5

[Nick Alexander :nalexander [he/him]]

I'd like to get this in under a separate bug number, so re-opening.

Comment 6

[Nick Alexander :nalexander [he/him]]

> r=nalexander, bug pleese format the commit line like:

But please.

Comment 7

[raymond [:retornam] (inactive)]

(In reply to Nick Alexander :nalexander from comment #6)
> > r=nalexander, bug pleese format the commit line like:
> 
> But please.

Thanks. I'll change the commit message and submit a new patch

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to raymond [:retornam] (needinfo? me) from comment #7)
> (In reply to Nick Alexander :nalexander from comment #6)
> > > r=nalexander, bug pleese format the commit line like:
> > 
> > But please.
> 
> Thanks. I'll change the commit message and submit a new patch

Do you have commit access?  If not, I'll land the patch for you, and I can update the commit message.

Comment 9

[raymond [:retornam] (inactive)]

(In reply to Nick Alexander :nalexander from comment #8)
> (In reply to raymond [:retornam] (needinfo? me) from comment #7)
> > (In reply to Nick Alexander :nalexander from comment #6)
> > > > r=nalexander, bug pleese format the commit line like:
> > > 
> > > But please.
> > 
> > Thanks. I'll change the commit message and submit a new patch
> 
> Do you have commit access?  If not, I'll land the patch for you, and I can
> update the commit message.
I dont have commit access, please update and land. Thanks

Comment 10

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/957e0c3927a1

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/957e0c3927a1

Comment 12

[raymond [:retornam] (inactive)]

Thanks everyone.

Comment 13

[Maksim Lin]

Sorry this breaks again because build-tools 19.0.1 is out now :-(