Closed Bug 941902 Opened 12 years ago Closed 11 years ago

GraphicBufferLocked should hold a sp<GraphicBuffer>, not a SurfaceDescriptor

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 985772

People

(Reporter: bjacob, Assigned: mtseng)

References

(Blocks 1 open bug)

Details

GraphicBufferLocked is a refcounted class, so its users should be able to assume that it remains valid as long as they hold on to it. But that's not the case, as it contains a SurfaceDescriptor, which can go bad at any time. It seems that it should just have a sp<GraphicBuffer> instead.
I think GraphicBufferLocked should hold TextureClient, not GraphicBuffer.
Assignee: nobody → mtseng
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.