Closed
Bug 941916
Opened 12 years ago
Closed 12 years ago
Drop unused constructor param "aItems" from SingleLineCrossAxisPositionTracker constructor
Categories
(Core :: Layout, defect, P4)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
3.11 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Filing this bug on dropping an unused parameter "const nsTArray<FlexItem>& aItems" in the SingleLineCrossAxisPositionTracker constructor.
|
Assignee | |
Comment 1•12 years ago
|
||
Here's the (trivial) patch.
(I almost landed this without review, but I figured I'd err on the safe side, since it is a [non-functional] code change.)
|
|
Assignee | |
Updated•12 years ago
|
OS: Linux → All
Priority: -- → P4
Hardware: x86_64 → All
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8336410 [details] [diff] [review]
fix v1
r=mats
Attachment #8336410 -
Flags: review?(matspal) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
Assignee | |
Comment 5•12 years ago
|
||
I realized one of the other args in this same constructor is also unused, so I pushed a followup to remove that one as well: https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd26577d093
|
||
Comment 6•12 years ago
|
||
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•