Closed Bug 941916 Opened 8 years ago Closed 8 years ago

Drop unused constructor param "aItems" from SingleLineCrossAxisPositionTracker constructor

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

fix v1
3.11 KB, patch
mats
: review+
Details | Diff | Splinter Review 
Filing this bug on dropping an unused parameter "const nsTArray<FlexItem>& aItems" in the SingleLineCrossAxisPositionTracker constructor.
Attached patch fix v1 — — Splinter Review 
Here's the (trivial) patch.

(I almost landed this without review, but I figured I'd err on the safe side, since it is a [non-functional] code change.)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8336410 - Flags: review?(matspal)
OS: Linux → All
Priority: -- → P4
Hardware: x86_64 → All
Comment on attachment 8336410 [details] [diff] [review]
fix v1

r=mats
Attachment #8336410 - Flags: review?(matspal) → review+
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/9a179f9b33ca
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
I realized one of the other args in this same constructor is also unused, so I pushed a followup to remove that one as well: https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd26577d093
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.