941993 - Sync interval check strings say "1 second".

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Reuben Morais [:reuben]]

See https://hg.mozilla.org/gaia-l10n/en-US/file/tip/apps/email/email.properties#l199

koi? since this affects 1.2.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Good catch on the English string plurals being wrong.  The good news is that the value 1 can never happen without modifying the code and those strings are never used in production.  See the comment on line 194 about the string only being used for debugging.  I think 20 seconds and 60 seconds are our hard-coded debug settings that have to be secretly enabled.

Clearing blocking request, but we should fix up the English string.  We can do this without changing the l10n id since it's just an error in English that is unlikely to be propagated to other languages.

Comment 2

[Reuben Morais [:reuben]]

Indeed, I read the comment a bit too quickly and misunderstood it. Thanks for the super fast triage.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attachment: fix the string nit, add an l10n note, have a comment that avoids :flod yelling at us ;)

Saw this bug was still around while doing some bug duping.  Might as well close it out since trunk is landable right now.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/25848
https://github.com/mozilla-b2g/gaia/commit/37bd98750a6aaaba9d185564afb92f5ee52e66fa