Closed
Bug 942020
Opened 12 years ago
Closed 12 years ago
[Flatfish][Clock] button in Timer & Stopwatch not big enough, right margin larger then left one
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ericcc, Assigned: gasolin)
Details
(Whiteboard: [Flatfish only][developer+] )
Attachments
(6 files, 1 obsolete file)
StopWatchReset.png
Gaia: f203faf80da3e0f5066c07c0f56913c605094266
Gecko: 5ebffa46852db6cb1c15f563f5995ee4356b1011
BuildID 20131122064537
Version 28.0a1
1. Open "Clock"
2. Tap "Stopwatch" -> Right margin of Reset button to border is larger then it on the left. (see StopwatchReset.png)
3. Tap "Start" -> Check "Lap" button (See StopWatchLap.png)
4. Tap "Timer", set any time to activate timer -> tap "Start" -> Right margin of Cancel button to border is larger then it on the left. (see TimerCancel.png)
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Comment 2•12 years ago
|
||
|
|
Reporter | |
Updated•12 years ago
|
blocking-b2g: --- → 1.3?
Flags: needinfo?(frlee)
|
|
||
Comment 3•12 years ago
|
||
hi Fred,
are we able to have a quick fix for this issue?
Flags: needinfo?(frlee)
|
Assignee | |
Comment 4•12 years ago
|
||
Eric, I attached the quick fix screenshot, is it acceptable?
I'll try to move buttons align to center...
Flags: needinfo?(echang)
|
|
Assignee | |
Comment 5•12 years ago
|
||
try to provide minimum change for clock app
Attachment #8336627 -
Flags: review?(iliu)
|
||
Comment 6•12 years ago
|
||
Comment on attachment 8336627 [details] [review]
pull request redirect to github
Fred,
Nit: Looks like the pause/cancel buttons are not align to central. I think it will be okay without the nit. Thanks.
Attachment #8336627 -
Flags: review?(iliu)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Comment on attachment 8336627 [details] [review]
pull request redirect to github
* make buttons align to center
* force Stopwatch buttons width to same size with timer (40%)
* make Timer use same top/bottom margin with Stopwatch
please kindly review it again, thanks
Attachment #8336627 -
Flags: review?(iliu)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Attachment #8336619 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•12 years ago
|
||
|
|
||
Comment 10•12 years ago
|
||
Comment on attachment 8336627 [details] [review]
pull request redirect to github
Looks good for me. CSS style patch only. Thanks.
Attachment #8336627 -
Flags: review?(iliu) → review+
|
|
Assignee | |
Comment 11•12 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/51562512953f58e91210966bc705a3804af06f8c
thanks!
Assignee: nobody → gasolin
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(echang)
Resolution: --- → FIXED
|
|
||
Comment 12•12 years ago
|
||
triage: not blocking on flatfish bugs; clearing flag since this already landed on master
blocking-b2g: 1.3? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•