Closed Bug 942029 Opened 9 years ago Closed 9 years ago

review suggestions only shows the first mentor

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file, 1 obsolete file)

the review extension's $bug.mentor field only returns the first mentor it finds.
as some bugs have multiple mentors, it should return an array.
Blocks: 869989
Attached patch 942029_1.patch (obsolete) — Splinter Review
Attachment #8336593 - Flags: review?(dkl)
Comment on attachment 8336593 [details] [diff] [review]
942029_1.patch

Review of attachment 8336593 [details] [diff] [review]:
-----------------------------------------------------------------

Overall works fine and looks good. One issue I found was that if a mentor is included that is also a component/product suggested reviewer, then their name is displayed twice. Please filter out the duplicates with the mentor entry taking precedence.
Attachment #8336593 - Flags: review?(dkl) → review-
Attached patch 942029_2.patchSplinter Review
Attachment #8336593 - Attachment is obsolete: true
Attachment #8343253 - Flags: review?(dkl)
Comment on attachment 8343253 [details] [diff] [review]
942029_2.patch

Review of attachment 8343253 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8343253 - Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Review/Extension.pm
modified extensions/Review/lib/WebService.pm
modified extensions/Review/template/en/default/hook/global/header-start.html.tmpl
modified extensions/Review/web/js/review.js
Committed revision 9169.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.