942067 - B2G RIL: apn type handled incorrectly in updateApnSettings(...) [v1.2]

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Attachment: reproducing bug 935537 with extra logs.

In Bug 935537, the cause of sending two consecutive radio power off requests to modem was because RIL didn't find out that there was an active data connection, so it set radio power off directly [1] (1st radio power off); later on, RIL receives an unsolicited data call list notifying that the active data connection was disconnected, from the logic in [2] we set radio power off again (2nd radio power off).

So the problem here is why RIL didn't find out about the activate data connection. The attached log (line 4076) with extra loggings shows that getDataCallStateByType(...) was called with type: "default,supl", which led us to think of a wrong apn type. Finally, we found the bug in apn settings type handling [3].

Bug 854626 (Part 5-1) has fixed this part in mozilla-central, but we still has this issue in v1.2

[1] http://mxr.mozilla.org/mozilla-aurora/source/dom/system/gonk/RadioInterfaceLayer.js#1523
[2] http://mxr.mozilla.org/mozilla-aurora/source/dom/system/gonk/RadioInterfaceLayer.js#1966
[3] http://mxr.mozilla.org/mozilla-aurora/source/dom/system/gonk/RadioInterfaceLayer.js#1577

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Jessica, I am wondering if you could take this bug? Thanks!

Comment 2

[Jessica Jong [:jessica] (inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> Jessica, I am wondering if you could take this bug? Thanks!

Oh yeah, I am running try on the patch: :)
https://tbpl.mozilla.org/?tree=Try&rev=2106dffbe91a

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8337648 [details] [diff] [review]
patch, v1.

for mozilla-b2g26_v1_2.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This is indeed a mistake that needs to be fixed. Otherwise, we will face problems when mms apn and internet apn have the same apn, user name and password. koi?

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8337648 [details] [diff] [review]
patch, v1.

Review of attachment 8337648 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this catch!

Comment 7

[Preeti Raghunath(:Preeti)]

Please provide better STRs and user impact here.

Comment 8

[Jessica Jong [:jessica] (inactive)]

(In reply to Preeti Raghunath(:Preeti) from comment #7)
> Please provide better STRs and user impact here.

Sorry for not being clearer.
This bug affects only carriers that have it's first apn with a single apn type and a second apn that can shared a former apn and that has more than one apn type. Like movistar's apn:
 {"carrier":"Movistar MMS","apn":"telefonica.es","user":"telefonica","password":"telefonica","mmsc":"http://mms.movistar.com","mmsproxy":"10.138.255.5","mmsport":"8080","type":["mms"]},
 {"voicemail":"123","enableStrict7BitEncodingForSms":true,"operatorSizeLimitation":512000,"type":["operatorvariant"]},
 {"carrier":"Movistar","apn":"telefonica.es","user":"telefonica","password":"telefonica","proxy":"10.138.255.133","port":"8080","type":["default","supl"]}

The user impact is not obvious, we found this bug by tracing Bug 935537 and the patch in Bug 935537 already solves the case. Another case might be when data connection is enabled and user edits the default APN. The original data connection is not really deactivated, and another data connection will be established with the new APN. However, user will not notice this.

Comment 9

[Preeti Raghunath(:Preeti)]

Thanks Jessica.

Did we see this issue with the Moz RIL or the Com RIL?

POVB?

Comment 10

[Jessica Jong [:jessica] (inactive)]

(In reply to Preeti Raghunath(:Preeti) from comment #9)
> Thanks Jessica.
> 
> Did we see this issue with the Moz RIL or the Com RIL?
> 
> POVB?

Preeti, we found this issue in Moz RIL, I am not sure about COM RIL as we don't have the source code. Maybe anshul can help answer this?

Comment 11

[Jason Smith [:jsmith]]

So here's the apn json for Gaia:

https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json

Jessica - Is the situation you are describing in comment 8 present in this apn.json file?

If it's present in the apn.json, then the situation you describe will affect those relevant carriers in any Gaia build. If it's not present, then this won't happen in any target Gaia build.

Comment 12

[Anshul]

Phil, could you please look at this issue from COM RIL's perspective?

Comment 13

[pgravel]

Does not affect commercial ril.

Comment 14

[Jessica Jong [:jessica] (inactive)]

(In reply to Jason Smith [:jsmith] from comment #11)
> So here's the apn json for Gaia:
> 
> https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json
> 
> Jessica - Is the situation you are describing in comment 8 present in this
> apn.json file?
> 
> If it's present in the apn.json, then the situation you describe will affect
> those relevant carriers in any Gaia build. If it's not present, then this
> won't happen in any target Gaia build.

Yes, it is the case of Telefonica ES (214-07).
Note that the issue is solved in master branch, so it affects those relevant carriers using 1.2 with any Gaia build.

Comment 15

[Jessica Jong [:jessica] (inactive)]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #14)
> (In reply to Jason Smith [:jsmith] from comment #11)
> > So here's the apn json for Gaia:
> > 
> > https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json
> > 
> > Jessica - Is the situation you are describing in comment 8 present in this
> > apn.json file?
> > 
> > If it's present in the apn.json, then the situation you describe will affect
> > those relevant carriers in any Gaia build. If it's not present, then this
> > won't happen in any target Gaia build.
> 
> Yes, it is the case of Telefonica ES (214-07).
> Note that the issue is solved in master branch, so it affects those relevant
> carriers using 1.2 with any Gaia build.

Oh, according to Comment 13, it does not affect commercial ril, so it affects those relevant carriers using 1.2 + MOZ RIL + any Gaia build.

Comment 16

[Preeti Raghunath(:Preeti)]

not a blocker as this is not impacting the comRIL.

Comment 17

[Jessica Jong [:jessica] (inactive)]

Closed per comment 16.