Closed
Bug 942147
Opened 11 years ago
Closed 11 years ago
Add identifying comments to existing entries in certdata.txt
Categories
(NSS :: CA Certificates Code, task)
Tracking
(Not tracked)
RESOLVED
FIXED
3.15.4
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(2 files)
|
380.35 KB,
patch
|
kathleen.a.wilson
:
review+
|
Details | Diff | Splinter Review |
|
4.42 KB,
text/plain
|
Details |
Old entries in certdata.txt are difficult to identify. They contain only one header comment, which states the "friendly name" or "label" the cert was given. Unfortunately that's often not sufficient to precisely identify a cert. Recently added certs already contain a full header. I've wrote a script to add equivalent headers to all the older entries. I'll attach a patch that will add comments, only, which will simplify future maintenance of the file.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8336791 -
Flags: review?(kwilson)
|
|
Assignee | |
Updated•11 years ago
|
QA Contact: kaie
|
|
Assignee | |
Comment 2•11 years ago
|
||
FYI, I wrote this script to create the enhanced certdata.txt file - only for reference purposes.
Assignee: nobody → kaie
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8336791 [details] [diff] [review] Patch v1 Review of attachment 8336791 [details] [diff] [review]: ----------------------------------------------------------------- Great improvement on the readability of this file. Looks good. Thanks!
Attachment #8336791 -
Flags: review?(kwilson) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/1cd59995c7e2
Target Milestone: --- → 3.15.4
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•