Closed
Bug 942207
Opened 11 years ago
Closed 11 years ago
Update NSPR to NSPR_4_10_3_BETA1 on trunk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: ted, Assigned: ted)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
37.61 KB,
patch
|
Details | Diff | Splinter Review |
This will pick up the fixes for bug 941461 and bug 932398.
Assignee | ||
Comment 1•11 years ago
|
||
For reference, results of "python client.py update_nspr NSPR_4_10_3_BETA1".
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e3e7a20399f
Comment 3•11 years ago
|
||
Backed out for mass ASAN sadness. https://hg.mozilla.org/integration/mozilla-inbound/rev/4409ec6a6482 https://tbpl.mozilla.org/php/getParsedLog.php?id=30974196&tree=Mozilla-Inbound
Comment 4•11 years ago
|
||
And OSX. https://tbpl.mozilla.org/php/getParsedLog.php?id=30975546&tree=Mozilla-Inbound
Comment 5•11 years ago
|
||
I'm seeing a smattering of greens that leads me to believe this was needs-clobber bustage. Please confirm that this is green on Try and then it can re-land with a touch of the CLOBBER file. Also, this'll probably need a Core::Build System bug filed for the needs-clobber.
Comment 6•11 years ago
|
||
All the PR_SyncMemMap changes have been green on try. The only other non-configure/build changes in the cset are two hunks in ptthread.c.
The forced clobber and retrigger on Ryan's merge went mostly green, so I guess this is needs-clobber.
Comment 8•11 years ago
|
||
ted: can I reland this for you?
Comment 9•11 years ago
|
||
Looks like Ted is out sick. Relanding with CLOBBER touched: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d4434514dc6
https://hg.mozilla.org/mozilla-central/rev/6d4434514dc6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 11•11 years ago
|
||
shouldn't the nspr version check be bumped up in configure.in because of a newly introduced NSPR API? My build against system-nspr 4.10.2 failed: /var/tmp/portage/www-client/nightly-9999/work/mozilla-central/dom/asmjscache/AsmJSCache.cpp:1127:7: error: use of undeclared identifier 'PR_SyncMemMap'; did you mean 'PR_MemMap'?
Assignee | ||
Comment 12•11 years ago
|
||
This patch didn't introduce any usage of that API, you probably want to complain to Luke in bug 929236...
Comment 13•11 years ago
|
||
(In reply to Walter Meinl from comment #11) Bug 9229236 did add a use of the new API added in this bug, which seems fine. Perhaps the system-nspr in question needs updating?
Comment 14•11 years ago
|
||
Oops, I mean bug 929236.
Comment 15•10 years ago
|
||
Yeah, please fix the configure check to require 4.10.3 (even if it doesnt exist yet), i also hit this build breakage when trying to build trunk with system nspr. /src/mozilla-central/dom/asmjscache/AsmJSCache.cpp:1511:7: error: use of undeclared identifier 'PR_SyncMemMap'; did you mean 'PR_MemMap'? if (PR_SyncMemMap(file->FileDesc(), ^~~~~~~~~~~~~ PR_MemMap /usr/local/include/nspr/prio.h:1847:18: note: 'PR_MemMap' declared here NSPR_API(void *) PR_MemMap( ^ /src/mozilla-central/dom/asmjscache/AsmJSCache.cpp:1511:21: error: cannot initialize a parameter of type 'PRFileMap *' with an rvalue of type 'PRFileDesc *'
Comment 16•10 years ago
|
||
Note that aurora is broken too. Should we file another bug on this ?
Comment 17•10 years ago
|
||
NSPR_4_10_3_BETA2 pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a4f5cd562cb
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•