942218 - Intermittent test_mobile_set_radio.js | got true, expected false | got false, expected true

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=30965924&tree=Mozilla-Inbound

b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-22 09:09:22 PST for push 4de097a9f7a6
slave: tst-linux64-ec2-093

09:30:18     INFO -  TEST-START test_mobile_set_radio.js
09:30:22     INFO -  /builds/slave/test/build/tests/marionette/tests/dom/network/tests/marionette/test_mobile_set_radio.js, runTest (marionette_test.MarionetteJSTestCase) ... FAIL
09:30:23     INFO -  START LOG:
09:30:23     INFO -  INFO TEST-START: /builds/slave/test/build/tests/marionette/tests/dom/network/tests/marionette/test_mobile_set_radio.js Fri Nov 22 2013 12:30:18 GMT-0500 (EST)
09:30:23     INFO -  INFO = testSwitchRadio = Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled to false Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: disabling Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: disabled Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled success Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled to true Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: enabling Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: enabled Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled success Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO = testDisableRadioWhenDataConnected = Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO Turn data on. Fri Nov 22 2013 12:30:19 GMT-0500 (EST)
09:30:23     INFO -  INFO mobileConnection.data.connected is now 'true'. Fri Nov 22 2013 12:30:21 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled to false Fri Nov 22 2013 12:30:21 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: disabling Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: disabled Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled success Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled to true Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: enabling Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO Received 'radiostatechange' event, radioState: enabled Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  INFO setRadioEnabled success Fri Nov 22 2013 12:30:22 GMT-0500 (EST)
09:30:23     INFO -  END LOG:
09:30:23     INFO -  ======================================================================
09:30:23     INFO -  FAIL: None
09:30:23     INFO -  ----------------------------------------------------------------------
09:30:23     INFO -  Traceback (most recent call last):
09:30:23     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette_test.py", line 143, in run
09:30:23     INFO -      testMethod()
09:30:23     INFO -    File "/builds/slave/test/build/tests/marionette/marionette/marionette_test.py", line 436, in runTest
09:30:23     INFO -      '%d tests failed:\n%s' % (results['failed'], '\n'.join(fails)))
09:30:23     INFO -  AssertionError: 1 tests failed:
09:30:23     INFO -  TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
09:30:23     INFO -  ----------------------------------------------------------------------
09:30:23     INFO -  Ran 1 test in 5.521s
09:30:23     INFO -  FAILED (failures=1)

Comment 1

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=30981250&tree=Mozilla-Central
b2g_emulator_vm mozilla-central opt test marionette-webapi on 2013-11-22 14:03:31
revision: 577cffd4656d
slave: tst-linux64-ec2-042

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-22 17:23:26.710    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 2

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=30988937&tree=Mozilla-Central
b2g_emulator_vm mozilla-central opt test marionette-webapi on 2013-11-22 17:11:55
revision: f7ad046f783f
slave: tst-linux64-ec2-032

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-22 20:31:35.384    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=30997267&tree=Mozilla-Central
b2g_emulator_vm mozilla-central opt test marionette-webapi on 2013-11-23 04:57:31
revision: bf99e325f238
slave: tst-linux64-ec2-052

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-23 08:18:24.679    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 4

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31013406&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-23 16:58:26
revision: fc4cac1204ab
slave: tst-linux64-ec2-118

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-23 20:17:15.543    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 5

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31030318&tree=Fx-Team
b2g_emulator_vm fx-team opt test marionette-webapi on 2013-11-24 19:35:21
revision: 4862074511a3
slave: tst-linux64-ec2-117

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-24 22:54:00.208    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 6

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31031208&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-24 20:26:39
revision: 3a9f42854971
slave: tst-linux64-ec2-082

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-24 23:46:21.327    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

I know the problem. It's indeed a bug. Fixing now

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: fix isRadioChanging

bug in original isRadioChanging()

when set radio off
1. deactivating data calls .. done
2. currently, we are not yet sent out the setRadioEnable request. so the state is not changed now.
3. isRadioChanging() return false.
4. radio interface will try to re-establish the data call because it is not in radioChanging.

data may be reconnected between (a) deactive data call and (b) send out setRadioEnabled.

Comment 9

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=31039126&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-25 04:01:38
revision: 9784574f93ef
slave: tst-linux64-spot-416

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-25 07:20:39.841    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 10

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=31047741&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-25 08:11:46
revision: af386935ce1f
slave: tst-linux64-ec2-059

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-25 11:33:09.059    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 11

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=31047741&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-25 08:11:46
revision: af386935ce1f
slave: tst-linux64-ec2-059

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-25 11:33:09.059    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8337639 [details] [diff] [review]
fix isRadioChanging

Review of attachment 8337639 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1614,5 @@
>    },
>  
>    _isRadioChanging: function _isRadioChanging() {
>      let state = this.rilContext.detailedRadioState;
> +    return gRadioEnabledController.isDeactivatingDataCalls() ||

Having this here doesn't make much sense as this function represents whether radio is changing. 

I think we should instead add one more condition check in "updateRILNetworkInterface."

Comment 13

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #12)
> Comment on attachment 8337639 [details] [diff] [review]
> fix isRadioChanging
> 
> Review of attachment 8337639 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/RadioInterfaceLayer.js
> @@ +1614,5 @@
> >    },
> >  
> >    _isRadioChanging: function _isRadioChanging() {
> >      let state = this.rilContext.detailedRadioState;
> > +    return gRadioEnabledController.isDeactivatingDataCalls() ||
> 
> Having this here doesn't make much sense as this function represents whether
> radio is changing. 
> 
> I think we should instead add one more condition check in
> "updateRILNetworkInterface."

updateRILNetworkInterface() is the only one caller for this function.
Did you mean moving "gRadioEnabledController.isDeactivatingDataCalls()" to updateRILNetworkInterface()
So it would be
  if (gRadioEnabledController.isDeactivatingDataCalls() || this.isRadioChanging()) ...

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #13)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #12)
> > Comment on attachment 8337639 [details] [diff] [review]
> > fix isRadioChanging
> > 
> > Review of attachment 8337639 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: dom/system/gonk/RadioInterfaceLayer.js
> > @@ +1614,5 @@
> > >    },
> > >  
> > >    _isRadioChanging: function _isRadioChanging() {
> > >      let state = this.rilContext.detailedRadioState;
> > > +    return gRadioEnabledController.isDeactivatingDataCalls() ||
> > 
> > Having this here doesn't make much sense as this function represents whether
> > radio is changing. 
> > 
> > I think we should instead add one more condition check in
> > "updateRILNetworkInterface."
> 
> updateRILNetworkInterface() is the only one caller for this function.
> Did you mean moving "gRadioEnabledController.isDeactivatingDataCalls()" to
> updateRILNetworkInterface()
> So it would be
>   if (gRadioEnabledController.isDeactivatingDataCalls() ||
> this.isRadioChanging()) ...

More specific, in [1]

    if (defaultDataCallState == RIL.GECKO_NETWORK_STATE_CONNECTING ||
        defaultDataCallState == RIL.GECKO_NETWORK_STATE_DISCONNECTING ||
        gRadioEnabledController.isDeactivatingDataCalls()) {
      if (DEBUG) {
        this.debug("Nothing to do during connecting/disconnecting in progress.");
      }
      return;
    }

[1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#1807

Comment 15

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #2 fix isRadioChanging

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8338307 [details] [diff] [review]
#2 fix isRadioChanging

Review of attachment 8338307 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 17

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [Final] Fix isRadioChanging. r=hsinyi

Comment 18

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=accf1dfacaea

Comment 19

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=31086367&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-26 01:45:26
revision: 426e66669b5a
slave: tst-linux64-ec2-110

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-26 05:05:15.115    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 20

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=31091741&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-26 04:54:16
revision: f57219215d8a
slave: tst-linux64-ec2-045

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-26 08:13:31.607    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/912b38085d2d

Comment 22

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=31116530&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-26 13:45:47
revision: fb5ae868b923
slave: tst-linux64-ec2-446

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-26 17:06:43.435    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 23

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31126700&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-26 17:12:26
revision: c6f465d6cfb0
slave: tst-linux64-ec2-116

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | got true, expected false | got false, expected true
Return code: 2560
11-26 20:33:55.866    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_mobile_set_radio.js | undefined - got true, expected false
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/912b38085d2d