94222 - radio shouldn't inherit from checkbox

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Chad Austin]

cuz hyatt says so!

Hopefully this will fix the very strange radiobutton behaviors from bug 959.

Comment 1

[Chad Austin]

Attachment: diff -u

Comment 2

[Chad Austin]

Neato.  It works.  (it probably isn't the best way though)

Here's a general overview of the problem:

When nsXULElement::Click() was fired on a button that would call
document.getElementById("whatever").click(), event.target wouldn't be updated to
reference the id='whatever' element.  To fix this (i.e. somehow let
HandleDOMEvent know that it should set a new target for the event), I made a new
message called NS_XUL_CLICK, which is special-cased (along with NS_XUL_* others)
in HandleDOMEvent.  When HandleDOMEvent sees NS_XUL_CLICK, it sets the new
target and then switches the message to NS_LEFT_MOUSE_CLICK so everything else
is processed normally.

Comment 3

[Chad Austin]

Oh, and so I don't forget, this needs to be repatched after 959 is checked in.

Comment 4

[David Hyatt]

Hey, neat hack.  I like it. :)

Comment 5

[Chad Austin]

I no longer have time for these.  Anyone else want to take them?

Comment 6

[David Hyatt]

Blake is fixing this one.

Comment 7

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 8

[jag (Peter Annema)]

Blake: I've included this patch in bug 959 since it needs it.

Comment 9

[chris hofmann]

time for 0.9.4 has run out.  try for 0.9.5. thanks -chofmann

Comment 10

[Chad Austin]

Take it, saari!  This'll be fixed with the patch in 959.

Comment 11

[Blake Ross]

-->me

Comment 12

[Blake Ross]

Fixed.