Closed Bug 942220 Opened 11 years ago Closed 11 years ago

Add explciit wait in tap_back in contact_details.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v1.3 wontfix)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.3 --- wontfix

People

(Reporter: zcampbell, Assigned: viorela)

Details

Attachments

(1 file)

added wait
46 bytes, text/x-github-pull-request
zcampbell
: review+
Bebe
: review-
AlinT
: review+
Details | Review 
In the method tap_back in contact_details.py there is no explicit wait after the tap to wait for the Details form page to have closed and the Contacts list to have displayed.

Please add an explicit wait here.
Assignee: nobody → viorela.ioia
Attached file added wait — 
pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/14015
Attachment #8337709 - Flags: review?(zcampbell)
Attachment #8337709 - Flags: review?(trifandreialin)
Attachment #8337709 - Flags: review?(florin.strugariu)
Attachment #8337709 - Flags: review?(andrei.hutusoru)
Attachment #8337709 - Flags: review?(trifandreialin) → review+
Comment on attachment 8337709 [details] [review]
added wait

Locally it worked OK but it fails on travis
Attachment #8337709 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8337709 [details] [review]
added wait

r- Fails on travis
Attachment #8337709 - Flags: review?(zcampbell) → review-
Attachment #8337709 - Flags: review?
Attachment #8337709 - Flags: review-
Attachment #8337709 - Flags: review?(zcampbell)
Attachment #8337709 - Flags: review?(florin.strugariu)
Attachment #8337709 - Flags: review?
Attachment #8337709 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8337709 [details] [review]
added wait

r+
Attachment #8337709 - Flags: review?(zcampbell)
Attachment #8337709 - Flags: review?(andrei.hutusoru)
Attachment #8337709 - Flags: review+
is this v1.3 affected?
v1.3 wontfix
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v1.3: --- → wontfix
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: