942314 - pagemod attachTo: ['existing', 'frames'] combination doesn't test iframe URLs against include

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

when using 'existing' and 'frames', pagemod scripts are included on any iframe where the top document (tab) URL matches the `include` option. 

for example, on a page at "foo.com" with an iframe from "bar.com", code like:

> attachTo: ['existing', 'frames'],
> include: 'foo.com',

included a script on the iframe from "bar.com", and code like:

> attachTo: ['existing', 'frames'],
> include: 'bar.com',

does not.

Comment 1

[Tomislav Jovanovic :zombie]

to try to make it more clear, the way it currently works without 'existing', if we have:

inside the addon
> attachTo: ['frames'],
> include: 'foo.com',

and we open a page at "foo.com" that has
> <iframe src='http://bar.com'></iframe>

the page-mod will not be attached to anything, as it should only attach to 'frames' from the "foo.com" domain, and our iframe is from the "bar.com" domain.

if we have that same page already open, and we add 'existing' to `attachTo`, the expected behavior would be exactly the same, page-mod not attached to anything.


currently, page-mod attaches to that iframe, when it shouldn't.

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: link to pr 1306

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a87414b7e07157f0f4ee1212b839aed995410281
bug 942314 - fix attachTo existing+frame combo

to only attach on iframes that match the include rules.

plus a test to verify it,

test when only iframe matches rules

another thing that didn't work

https://github.com/mozilla/addon-sdk/commit/601c7e4717be871f639171b63138ebce11fa505e
Merge pull request #1306 from zombie/942314-existing-frame

fix bug 942314 - fix attachTo existing+frame combo r=@ZER0

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8337178 [details] [review]
link to pr 1306

Actually forget to r+ on bugzilla after merging the a month ago…