Closed
Bug 942339
Opened 11 years ago
Closed 11 years ago
Modify SMS App Scrollable Area to stay in 1 active layer
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
1.2 C6(Dec6)
People
(Reporter: mchang, Assigned: mchang)
References
Details
(Keywords: perf, Whiteboard: [c=handeye p=3 s= u=])
Attachments
(1 file)
672 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Modify SMS app so that the scrollable area has the will-animate property.
Comment 1•11 years ago
|
||
How do we do that?
Comment 2•11 years ago
|
||
Once bug 940842 is ready we just need to add the new CSS property.
Assignee | ||
Comment 3•11 years ago
|
||
Patch attached to enable will-animate. Tested on reference-workload-light with the SMS app and clicking into a single message. Nice that both scrollable areas are in the same div.
Comment 4•11 years ago
|
||
Ok, great idea :) I never liked the idea of abusing 3D translate transformations to do this.
Will this be prefixed, or hidden behind a pref, or something?
Comment 5•11 years ago
|
||
I imagine for now it will be restricted to b2g app until it's accepted.
Assignee | ||
Comment 6•11 years ago
|
||
Dropbox video with patch applied:
https://www.dropbox.com/s/221ih9d0pbcwlq3/Video%20Dec%2002%2C%2010%2017%2038%20AM.mov
Assignee | ||
Updated•11 years ago
|
Attachment #8337916 -
Flags: review?(bgirard)
Comment 7•11 years ago
|
||
Comment on attachment 8337916 [details] [diff] [review]
smsWillScroll.patch
Review of attachment 8337916 [details] [diff] [review]:
-----------------------------------------------------------------
r=me because this is a platform hint. The only behavioral change is forcing a stacking context.
Attachment #8337916 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 10•11 years ago
|
||
master: 9898d5c527e0f74855b7431d50d0148c6e0a6faa
Updated•11 years ago
|
Depends on: will-change
You need to log in
before you can comment on or make changes to this bug.
Description
•