942429 - Right clicking the DevTools CodeMirror source editor creates a light white square

Status: RESOLVED WORKSFORME

(DevTools :: Source Editor, defect, P3)

Description

[Tim Nguyen :ntim]

This is mainly visible in DevTools Dark theme.
I'll attach a screenshot soon.

Comment 1

[Marijn Haverbeke]

This is caused by the kludge CodeMirror uses to enable copy/paste/select-all in the context menu, even though a non-editable element is clicked. It moves the hidden textarea below the mouse pointer at the last moment, makes it mostly transparent, and lets the click take effect there.

The textarea used to be assigned a white background. Patch [1] makes it transparent. Maybe try if that helps?

[1]: https://github.com/marijnh/CodeMirror/commit/c3b38d016f990c16e126b0fb024fbd2c92656c22

Comment 2

[Anton Kovalyov (:anton)]

This bug, while important, doesn't block the CodeMirror integration meta-bug.

Comment 3

[Tim Nguyen :ntim]

(In reply to Marijn Haverbeke from comment #1)
> This is caused by the kludge CodeMirror uses to enable copy/paste/select-all
> in the context menu, even though a non-editable element is clicked. It moves
> the hidden textarea below the mouse pointer at the last moment, makes it
> mostly transparent, and lets the click take effect there.
> 
> The textarea used to be assigned a white background. Patch [1] makes it
> transparent. Maybe try if that helps?
> 
> [1]:
> https://github.com/marijnh/CodeMirror/commit/
> c3b38d016f990c16e126b0fb024fbd2c92656c22


The color should also be transparent, since you can also type in that textarea.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Anton, is this still on your radar? I noticed it in a batch of UNCONFIRMED Firefox 28 bugs. Is it something that should stay open, or be closed, or should be brought to someone else's notice? Thanks!

Comment 5

[Tim Nguyen :ntim]

(In reply to Liz Henry :lizzard from comment #4)
> Anton, is this still on your radar? I noticed it in a batch of UNCONFIRMED
> Firefox 28 bugs. Is it something that should stay open, or be closed, or
> should be brought to someone else's notice? Thanks!
You can mark this as RESOLVED FIXED, since the issue no longer happens. It was probably fixed with a recent update of codemirror in Firefox.

Comment 6

[Anton Kovalyov (:anton)]

Marking as RESOLVED FIXED since the issue no longer exists. Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

WFM unless you know what actually fixed it.