Closed Bug 942453 Opened 6 years ago Closed 6 years ago

Handlify IndexToId

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch indextoidSplinter Review
I wasn't sure about the NoGC version using it.
Attachment #8337268 - Flags: review?(terrence)
Comment on attachment 8337268 [details] [diff] [review]
indextoid

Review of attachment 8337268 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

::: js/src/jsobjinlines.h
@@ +577,5 @@
>      if (op)
>          return false;
>  
>      jsid id;
> +    if (!js::IndexToIdPure(index, &id)) // ??

This isn't quite the same as I would expect for IndexToIdNoGC, so I don't think we should rename. I think it would actually be quite a bit clearer to lift the implementation to this method and kill IndexToIdPure. That's a bit out of scope for this patch so feel free to just leave it.
Attachment #8337268 - Flags: review?(terrence) → review+
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/0270980e1c05
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.