test_user_agent_updates.html,test_user_agent_overrides.html intermittently fails to unset its override of the UA string | test_videocontrols_standalone.html | Height of audio element should be 28, which is equal to the controls bar. - got 123, expected 28

RESOLVED FIXED in 1.3 Sprint 6 - 12/6

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: philor, Assigned: jchen)

Tracking

unspecified
1.3 Sprint 6 - 12/6
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
See either https://tbpl.mozilla.org/php/getParsedLog.php?id=31007226&tree=Try#error0 or all of bug 923597 - test_handlerApps.xhtml is disabled on OS X 10.8 by way of navigator.userAgent.indexOf("Mac OS X 10.8") != -1, but intermittently instead of including that string in the UA and thus not running that failing test, we have a UA of "DummyUserAgent" so we run the test and fail it.

Might be a nice touch to have test_user_agent_updates.html grab the unaltered UA string at the start, and test that it is back to that at the end, so if this crops up again I won't have to guess that some later test is failing because we're running DummyUserAgent rather than the browser we thought we were running.
Jim, can you please look at this? Bug 923597 happens quite frequently.
Flags: needinfo?(nchen)
(Assignee)

Comment 2

4 years ago
Yes, I'm looking at it today. The fix should be fairly straightforward but I want to first find out why it only happens intermittently.
Flags: needinfo?(nchen)
Summary: test_user_agent_updates.html intermittently fails to unset its override of the UA string → test_user_agent_updates.html intermittently fails to unset its override of the UA string | test_videocontrols_standalone.html | Height of audio element should be 28, which is equal to the controls bar. - got 123, expected 28
See bug 943556 which has been the incorrect target for some of the oranges that have been appearing due to the "DummyUserAgent". I've updated the bug summary for this bug to help it get found on TBPL.
(Reporter)

Comment 4

4 years ago
Disabled in https://hg.mozilla.org/integration/mozilla-inbound/rev/011548874d7e
Whiteboard: [test disabled][leave open]
(Reporter)

Comment 5

4 years ago
Wups, that first one was test_user_agent_overrides.html, and as https://tbpl.mozilla.org/php/getParsedLog.php?id=31361326&tree=Mozilla-Inbound a few pushes later showed, I did want to disable test_user_agent_updates.html too; https://hg.mozilla.org/integration/mozilla-inbound/rev/94f5ee227f40
Summary: test_user_agent_updates.html intermittently fails to unset its override of the UA string | test_videocontrols_standalone.html | Height of audio element should be 28, which is equal to the controls bar. - got 123, expected 28 → test_user_agent_updates.html,test_user_agent_overrides.html intermittently fails to unset its override of the UA string | test_videocontrols_standalone.html | Height of audio element should be 28, which is equal to the controls bar. - got 123, expected 28
https://hg.mozilla.org/mozilla-central/rev/011548874d7e
(Assignee)

Updated

4 years ago
Assignee: nobody → nchen
https://hg.mozilla.org/mozilla-central/rev/94f5ee227f40
Flags: in-testsuite-
(Assignee)

Comment 8

4 years ago
Created attachment 8342668 [details] [diff] [review]
Don't apply user agent update if updates have been disabled (v1)

I think the intermittent failure happens when we disable updates while there is still a pending network request. When the network request completes, we inadvertently apply the update even though we should be disabled.

This patch checks for the enabled pref when applying updates, to make sure pending network requests are ignored. The patch also adds a test to make sure the UA is reverted and re-enables the disabled tests.

Try run suggests the intermittent failure is fixed by this patch, https://tbpl.mozilla.org/?tree=Try&rev=3cdb5c00f717
Attachment #8342668 - Flags: review?(fabrice)
Attachment #8342668 - Flags: review?(fabrice) → review+
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/906f5a720000
Flags: in-testsuite- → in-testsuite+
Keywords: checkin-needed
Whiteboard: [test disabled][leave open]
https://hg.mozilla.org/mozilla-central/rev/906f5a720000
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.