942502 - Move EGLImage/GraphicBuffer-specific helpers out of GLContext

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Talking about this bit of GLContext.h:

    virtual bool BindExternalBuffer(GLuint texture, void* buffer) { return false; }
    virtual bool UnbindExternalBuffer(GLuint texture) { return false; }

#ifdef MOZ_WIDGET_GONK
    virtual EGLImage CreateEGLImageForNativeBuffer(void* buffer) = 0;
    virtual void DestroyEGLImage(EGLImage image) = 0;
#endif

    virtual already_AddRefed<TextureImage>
    CreateDirectTextureImage(::android::GraphicBuffer* aBuffer, GLenum aWrapMode)
    { return nullptr; }

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Expected difficulty: intermediate.

Nontrivial as custom choices will have to be made for each place in Gecko that was relying on that, but I expect that there won't be too many (DXR to the rescue).

Comment 2

[u480271]

Attachment: Remove dead code.

In preparation, BindExternalBuffer/UnbindExternalBuffer appear to be dead code.

Try run to check: https://tbpl.mozilla.org/?tree=Try&rev=0ebf5416840f

Comment 3

[u480271]

Attachment: Move EGLImage/GraphicBuffer-specific helpers out of GLContext

Extracted methods CreateEGLImageForNativeBuffer and DestroyEGLImage from
GLContext and moved to EGLImageHelpers.[h|cpp]. Renamed to
EGLImageCreateFromNativeBuffer and EGLImageDestroy.

Comment 4

[u480271]

https://tbpl.mozilla.org/?tree=Try&rev=971e97059ee7

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8344469 [details] [diff] [review]
Move EGLImage/GraphicBuffer-specific helpers out of GLContext

Review of attachment 8344469 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with this:

::: gfx/layers/moz.build
@@ +183,5 @@
>  # has full system permissions there.
>  if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
>      EXPORTS.mozilla.layers += [
>          'ipc/ShadowLayerUtilsGralloc.h',
> +        'opengl/EGLImageHelpers.h'

If I am not mistaken, this header is only #included by source files in the same directory, so you don't need to export it. Better not export headers until we need to.

Comment 6

[u480271]

Attachment: Move EGLImage/GraphicBuffer-specific helpers out of GLContextExtracted methods CreateEGLImageForNativeBuffer and DestroyEGLImage from

Update with review comments from bjacob.

https://tbpl.mozilla.org/?tree=Try&rev=2e72d104d6f6

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fd0594ff74ce
http://hg.mozilla.org/integration/mozilla-inbound/rev/be500431a9d6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be500431a9d6
https://hg.mozilla.org/mozilla-central/rev/fd0594ff74ce