942573 - [Feedback] Small mistake in done message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Julen Ruiz Aizpuru]

When the process of providing feedback has been terminated, the en-US message displays the following:

feedback-done-msg="Thanks for the feedback! We will use it to help us create a better experience in future release of Firefox OS."

The last sentence has a small mistake. It should say, either

- "in a future release of Firefox OS.", or
- "in future releases of Firefox OS."

Comment 1

[Francesco Lodolo [:flod]]

Another question for Matej (your lucky day) :-)

I agree that the current English string sounds wrong.
http://hg.mozilla.org/gaia-l10n/en-US/file/default/apps/settings/settings.properties#l1138

P.S. another string that we probably want to fix without new ID, to avoid creating unnecessary noise

Comment 2

[Matej Novak [:matej]]

A few little tweaks:

feedback-done-msg="Thanks for the feedback! We use it to help create better experiences in future releases of Firefox OS."

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Updated text

In the end I used a new ID, since there are a few changes that I'd link localizers to consider for their translations (like "we'll use->we use", undetermined future vs now).

Fun fact: the string was correct in the .html file ("in future releases"), bad copy and paste to the .properties file. Sad face.

Comment 4

[Evelyn Hung]

Comment on attachment 8388362 [details] [review]
Updated text

Feel good to take this patch. Please make sure to catch our localization team's attention if this is a late-l10n change.

Comment 5

[Francesco Lodolo [:flod]]

Thanks, setting checkin-needed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: a2cf9f0e4d702011fca1d0ff6234de4bd2efcad5