Closed Bug 942573 Opened 9 years ago Closed 9 years ago

[Feedback] Small mistake in done message


(Firefox OS Graveyard :: Gaia::Settings, defect)

Not set


(b2g-v1.4 fixed)

1.4 S3 (14mar)
Tracking Status
b2g-v1.4 --- fixed


(Reporter: julenx, Assigned: flod)



(1 file)

46 bytes, text/x-github-pull-request
: review+
Details | Review
When the process of providing feedback has been terminated, the en-US message displays the following:

feedback-done-msg="Thanks for the feedback! We will use it to help us create a better experience in future release of Firefox OS."

The last sentence has a small mistake. It should say, either

- "in a future release of Firefox OS.", or
- "in future releases of Firefox OS."
Another question for Matej (your lucky day) :-)

I agree that the current English string sounds wrong.

P.S. another string that we probably want to fix without new ID, to avoid creating unnecessary noise
Flags: needinfo?(Mnovak)
Assignee: nobody → francesco.lodolo
Keywords: l12y
A few little tweaks:

feedback-done-msg="Thanks for the feedback! We use it to help create better experiences in future releases of Firefox OS."
Flags: needinfo?(Mnovak)
Attached file Updated text
In the end I used a new ID, since there are a few changes that I'd link localizers to consider for their translations (like "we'll use->we use", undetermined future vs now).

Fun fact: the string was correct in the .html file ("in future releases"), bad copy and paste to the .properties file. Sad face.
Attachment #8388362 - Flags: review?(ehung)
Comment on attachment 8388362 [details] [review]
Updated text

Feel good to take this patch. Please make sure to catch our localization team's attention if this is a late-l10n change.
Attachment #8388362 - Flags: review?(ehung) → review+
Thanks, setting checkin-needed.
Keywords: checkin-needed
Master: a2cf9f0e4d702011fca1d0ff6234de4bd2efcad5
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in before you can comment on or make changes to this bug.