942620 - do you want to cancel download dialog appears twice on ctrl-w on last open tab

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[scientes]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131123030208

Steps to reproduce:

last tab is open
press ctrl-w


Actual results:


"do you want to cancel download" -> don't cancel
"do you want to cancel download" again


Expected results:

only once

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/679713792647
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130821141109
Bad:
http://hg.mozilla.org/mozilla-central/rev/438cc1848c96
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130821141404
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=679713792647&tochange=438cc1848c96

Triggered by: Bug 847863

Comment 2

[Josh Matthews [:jdm]]

Oh, do we still instantiate the nsIDownloadManager service? If it's still setting up observers, that would definitely cause this behaviour. We probably see the same thing closing an open private window with active downloads.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Given how late we are in the Firefox 26 beta cycle (building our second-to-last beta today) this regression will have to go unfixed.  It's an unfortunate glitch in the behaviour but without time to test & verify a fix in our Beta audience we'll have to wait until FF27.  Ni? on Paolo (who is apparently intermittently available this week) to see if there is anything very low risk that could be considered *today* for Beta 9 - would hold a bit for that - otherwise wontfix for 26.

Comment 4

[:Paolo Amadini]

(In reply to [e-mail] [:lsblakk] from comment #3)
> if there is anything
> very low risk that could be considered *today* for Beta 9 - would hold a bit
> for that - otherwise wontfix for 26.

This will require some debugging to understand what's going on exactly, I don't have a solution today. This will indeed need to be fixed in the late Aurora 27.

Comment 5

[bhavana bajaj [:bajaj]]

NI on :paolo to help with next steps here as we are only a couple of beta's away from shipping Firefox 27.

Comment 6

[:Paolo Amadini]

Attachment: Fix double "quit-application-requested" notification

This bug is due to a double quit notification in the CTRL-W case when quit is cancelled. Not sure who can best review this code. Gavin?

Comment 7

[bhavana bajaj [:bajaj]]

We're past the time for speculative fixes on beta, so this is going to be a wontfix there but still tracking for potential forward fix if low-risk enough to take to FF28

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Paolo: what's the status here? Can we get this landed and on beta ASAP?

Comment 9

[:Paolo Amadini]

(In reply to :Gavin Sharp (email [e-mail]) from comment #8)
> Paolo: what's the status here? Can we get this landed and on beta ASAP?

I was looking into this and had just started a tryserver build:

https://tbpl.mozilla.org/?tree=Try&rev=a786ad335e03

If this is green I think the patch can be checked in.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/7669356ea113

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7669356ea113

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Ready for approval requests?

Comment 13

[:Paolo Amadini]

Comment on attachment 8361003 [details] [diff] [review]
Fix double "quit-application-requested" notification

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Maybe triggered by bug 847863, unclear if it was a pre-existing issue
User impact if declined: Need to cancel quit twice in case of in-progress downloads when using the CTRL+W keyboard shortcut to close the last tab
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Probably safe for Aurora, there is a slight chance of unforeseen regressions as the change involves the global quit notifications in the CTRL+W case
String or IDL/UUID changes made by this patch: None

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8361003 [details] [diff] [review]
Fix double "quit-application-requested" notification

We are early in the aurora process. So, if side effects, we can still fix them later.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/452f9c9477d2

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Looks like this is too risky for Beta, so wontfixing there, we'll get it in 29.

Comment 17

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2013-11-26.
Verified fixed 30.0a1 (2014-03-10), 29.0a2 (2014-03-10) Win 7 x64.