942702 - [Flatfish][Settings] Background color of title bar and section title bar are white|gray instead of dark gray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: Settings.png

1. Open "Settings".
2. Every bar in pages inside "Settings" are with white|gray background instead of dark gray
3. Check attachments for information.(P.S. Only 4 pages are included in attachment, please go through all pages, thanks)

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: MoreInformation.png

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: DeviceInformation.png

Comment 3

[Eric Chang [:ericcc] [:echang]]

Attachment: Bluetooth.png

Comment 4

[Eric Chang [:ericcc] [:echang]]

Gaia:     c736d91f6a1aada7b81a3d7b7df2635f2f9a655a  │  
Gecko:    bdad895da779dab239298c3b23e9c28b37544071  │  
BuildID   20131125064537                            │  
Version   28.0a1                                    │  
ro.build.version.incremental=20131125

Comment 5

[Francis Lee [:frlee]]

this is a bug and we need to address it, change it to 1.3+

hi Fred,

are you able to have someone to fix it?

Comment 6

[[e-mail]]

Francis,

It's because building block just changed its origin style
https://groups.google.com/forum/#!topic/mozilla.dev.gaia/w-SyenHtAAE

this will be done in settings/gallery tablet patch, we'll overwrite the style to follow tablet design. 


Mike,

Should we stick with the origin style, or change to the new one?

Comment 7

[GoodMike]

Let's talk tomorrow and deliver solution here, Fred. However, from our spec, the Settings should have two panes in landscape mode.

Comment 8

[[e-mail]]

We already landed two panes in landscape mode, and overwrite Background color of title bar to original one. Please kindly check if there's any followup work for the style, thanks.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Not taking Flatfish patches to 1.3 branch, but patch is very welcome.

Comment 10

[Sherman Chen [:chens] (inactive)]

This issue is fixed in master.