Closed
Bug 942704
Opened 11 years ago
Closed 11 years ago
[Status bar] Followup of bug 936201, considering activity.
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: alive, Assigned: gasolin)
References
Details
Attachments
(2 files)
STR:
1. In homescreen
2. Longpress
3. Choose wallpaper activity
4. Wait it is opened.
Expected:
Statusbar is not semitransparent.
Actual:
Statusbar is semitransparent.
Note:
One line patch: Consider activityopening event in statusbar as well as appopening.
+++ This bug was initially created as a clone of Bug #936201 +++
Spoke to Peter and decided to go even darker for the status bar headers.
#20282e
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8339704 -
Flags: review?(alive)
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 8339704 [details] [review]
pull request redirect to github
Github
Attachment #8339704 -
Flags: review?(alive)
Assignee | ||
Updated•11 years ago
|
Attachment #8339704 -
Flags: review?(alive)
Reporter | ||
Updated•11 years ago
|
Attachment #8339704 -
Flags: review?(alive) → review+
Assignee | ||
Comment 4•11 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/ee1bfd4a260e732264f8486cbf62197760de984a
thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
I don't think the problem come from the 'activity'.
On the homescreen this 'contextmenu' is managed by contextmenu.js
which is a fake contextmenu controlled by the Homescreen app not the System app.
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•11 years ago
|
||
Sam, so you think the problem is 'the statusbar is transparent while contextmenu is triggered', right?
Any app's fake context menu can't control the statusbar transparency though...
Comment 8•11 years ago
|
||
Also https://bugzilla.mozilla.org/show_bug.cgi?id=936201 need to be backout as this one involved conflicted i backed out this one too.
revert commit: d41da2a45d55f53b621e03d808d00fec67ef9f3b
Comment 9•11 years ago
|
||
Well if the app handle its own fake contextmenu, yes it won't control the statusbar.
Updated•11 years ago
|
Comment 10•11 years ago
|
||
With the backout in bug 936201, this issue is no longer present in the build, so I'm closing this out. We can take care of this in an updated patch on bug 936201.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 11•11 years ago
|
||
Verified that the status bar is not semitransparent.
Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131205040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/725c36b5de1a
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Platform Version: 28.0a1
Firmware Version: 20131115
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•