Closed Bug 942706 Opened 11 years ago Closed 11 years ago

Remove nsIPluginTagInfo::getDocumentEncoding()

Categories

(Core Graveyard :: Plug-ins, defect)

All
Android
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(1 file)

It looks like nsIPluginTagInfo::getDocumentEncoding() has no callers in m-c. Since XPCOM plug-ins are dead, my understanding is there aren't plug-in callers, either. If that's the case, we should remove this method as dead code. It keeps causing concern when it shows up on searches by people who work on encodings.
Looks like this exists for http://www-archive.mozilla.org/projects/blackwood/java-plugins/api/org/mozilla/pluglet/mozilla/PlugletTagInfo2.html . Also looks like we don't support that stuff and there's some more adjacent dead code.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
(In reply to Henri Sivonen (:hsivonen) from comment #0)
> It looks like nsIPluginTagInfo::getDocumentEncoding() has no callers in m-c.
> Since XPCOM plug-ins are dead, my understanding is there aren't plug-in
> callers, either.

For what its worth, this matches my understanding.
Attachment #8337626 - Flags: review?(jschoenick)
Comment on attachment 8337626 [details] [diff] [review]
Remove dead code and flatten out the interface

Review of attachment 8337626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for cleaning this up!
Attachment #8337626 - Flags: review?(jschoenick) → review+
https://hg.mozilla.org/mozilla-central/rev/4446b19237a2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: