Closed
Bug 942711
Opened 11 years ago
Closed 10 years ago
Test failure 'Add-ons Manager has been closed.' across several tests
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox26 fixed, firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 fixed)
People
(Reporter: andrei, Assigned: mario.garbi)
References
()
Details
(Whiteboard: [mozmill-test-failure])
Attachments
(6 files, 5 obsolete files)
1.06 MB,
image/png
|
Details | |
2.59 KB,
patch
|
AndreeaMatei
:
review+
andrei
:
review-
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
2.59 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
2.67 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
2.66 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
Module: teardownModule Test: /restartTests/testAddons_enableDisableExtension/test4.js Failure: Add-ons Manager has been closed. Branches: default Platforms: Windows XP Sample report: http://mozmill-daily.blargon7.com/#/functional/report/456bebe92845279408c15c03e871330b This has failed 4 times over the weekend, on Windows XP, with Nightly.
Reporter | ||
Comment 1•11 years ago
|
||
Interestingly we have the same failure in some endurance tests, again windows: XP: http://mozmill-daily.blargon7.com/#/endurance/report/456bebe92845279408c15c03e88b1ad5 Vista: http://mozmill-daily.blargon7.com/#/endurance/report/456bebe92845279408c15c03e8746e9a http://mozmill-daily.blargon7.com/#/endurance/report/456bebe92845279408c15c03e88b2442
Reporter | ||
Comment 2•11 years ago
|
||
I've failed to reproduce any of the failures above on a WinXP box
Assignee | ||
Comment 3•11 years ago
|
||
Happened again on Windows NT 6.0.6002 Service Pack 2 (x86) with Firefox 28.0a1 en-US: http://mozmill-daily.blargon7.com/#/endurance/report/b99421c0f132c68dec1548288a019035 and Windows NT 5.1.2600 Service Pack 3 (x86): http://mozmill-daily.blargon7.com/#/endurance/report/b99421c0f132c68dec1548288a0191d5
Comment 4•11 years ago
|
||
Happened again on windows xp x86 with Nightly en-US http://mozmill-daily.blargon7.com/#/endurance/report/b99421c0f132c68dec1548288a6cdc90 and on windows vista x86 with Nightly en-US http://mozmill-daily.blargon7.com/#/endurance/report/b99421c0f132c68dec1548288a6ca034
OS: Windows XP → All
Updated•10 years ago
|
Assignee: nobody → cosmin.malutan
Summary: Test failure 'Add-ons Manager has been closed.' in /restartTests/testAddons_enableDisableExtension/test4.js → Test failure 'Add-ons Manager has been closed.' across several tests
Assignee | ||
Comment 5•10 years ago
|
||
I managed to reproduce it locally, will look into it. http://mozmill-crowd.blargon7.com/#/endurance/report/8ff37f5518a39f6af2983cfe44028edb
Assignee: cosmin.malutan → mario.garbi
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•10 years ago
|
||
Just to reiterate which tests are affected, we've seen this fail in: functional/restartTests/testAddons_enableDisableExtension/test4.js functional/testAddons/testManagerKeyboardShortcut.js endurance/testAddons_OpenAndCloseExtensionList/test1.js endurance/testAddons_OpenAndCloseGetAddonsPane/test1.js I think I've only seen this on 28
status-firefox28:
--- → affected
Assignee | ||
Comment 7•10 years ago
|
||
This happens due to us setting "about:home" as the value for "extensions.webservice.discoverURL" preference. I have tested this using a minimized test and it happens 2/3 time on winXP. As can be seen from the attached screenshot we open a third tab when we open the addonManager. I will further look into why this is happening and how to fix the issue while keeping the preference that speeds up our addon tests considerably.
Assignee | ||
Comment 8•10 years ago
|
||
The issue here was that we were clicking the middle mouse button to close the addon manager before the tab was fully loaded and therefore hitting the tab bar, opening a new about:blank tab. The fix here was removes the open tab animation and therefore solves our problem as well as adding to the test speed. http://mozmill-crowd.blargon7.com/#/endurance/report/ca1869364f98dd0de71202e01e1b3e10
Attachment #8346557 -
Flags: review?(andrei.eftimie)
Attachment #8346557 -
Flags: review?(andreea.matei)
Comment 9•10 years ago
|
||
Comment on attachment 8346557 [details] [diff] [review] addonManagerTabAnimation.patch Review of attachment 8346557 [details] [diff] [review]: ----------------------------------------------------------------- This is just a bad workaround. We generally have the tab animation turned on now, so tests which make use of the addon manager should properly handle the animation.
Attachment #8346557 -
Flags: review?(andrei.eftimie)
Attachment #8346557 -
Flags: review?(andreea.matei)
Attachment #8346557 -
Flags: review-
Comment 10•10 years ago
|
||
Failed on endurance with Nightly, Windows XP Tests: testAddons_OpenAndCloseExtensionList/test1.js and testAddons_OpenAndCloseGetAddonsPane/test1.js: http://mozmill-daily.blargon7.com/#/endurance/report/ca1869364f98dd0de71202e01e254b0f
status-firefox29:
--- → affected
Reporter | ||
Comment 11•10 years ago
|
||
This has failed several times during the weekend. Tempted to raise the priority. Mario any update?
Flags: needinfo?(mario.garbi)
Assignee | ||
Comment 12•10 years ago
|
||
Updated the patch to wait for the "transitionend" event, which also fixes the problem. Linux: http://mozmill-crowd.blargon7.com/#/endurance/report/ca1869364f98dd0de71202e01ea84a4a Windows: http://mozmill-crowd.blargon7.com/#/endurance/report/ca1869364f98dd0de71202e01ea850ab Mac: http://mozmill-crowd.blargon7.com/#/endurance/report/ca1869364f98dd0de71202e01ea84b1c
Attachment #8346557 -
Attachment is obsolete: true
Attachment #8348101 -
Flags: review?(hskupin)
Attachment #8348101 -
Flags: review?(andrei.eftimie)
Attachment #8348101 -
Flags: review?(andreea.matei)
Flags: needinfo?(mario.garbi)
Comment 13•10 years ago
|
||
Comment on attachment 8348101 [details] [diff] [review] waitForTabAnimation.patch Review of attachment 8348101 [details] [diff] [review]: ----------------------------------------------------------------- Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/b63a467a043c (default)
Attachment #8348101 -
Flags: review?(hskupin)
Attachment #8348101 -
Flags: review?(andrei.eftimie)
Attachment #8348101 -
Flags: review?(andreea.matei)
Attachment #8348101 -
Flags: review+
Updated•10 years ago
|
Assignee | ||
Comment 14•10 years ago
|
||
Backport for Beta and Release. We can use the initial patch for Aurora.
Attachment #8348626 -
Flags: review?(andrei.eftimie)
Attachment #8348626 -
Flags: review?(andreea.matei)
Assignee | ||
Comment 15•10 years ago
|
||
Backport patch for ESR24
Attachment #8348637 -
Flags: review?(andrei.eftimie)
Attachment #8348637 -
Flags: review?(andreea.matei)
Reporter | ||
Comment 16•10 years ago
|
||
Comment on attachment 8348626 [details] [diff] [review] waitForTabAnimation_Beta.patch Review of attachment 8348626 [details] [diff] [review]: ----------------------------------------------------------------- ::: firefox/lib/addons.js @@ +173,5 @@ > } > } > finally { > + this._tabBrowser._tabs.getNode().removeEventListener("transitionend", > + checkTabTransitioned); Please leave this in the same order as in the default & aurora patch. We'll get merge conflicts later on if we have a different order.
Attachment #8348626 -
Flags: review?(andrei.eftimie)
Attachment #8348626 -
Flags: review?(andreea.matei)
Attachment #8348626 -
Flags: review-
Assignee | ||
Comment 17•10 years ago
|
||
Updated the patch with a nit.
Attachment #8348626 -
Attachment is obsolete: true
Attachment #8348688 -
Flags: review?(andrei.eftimie)
Attachment #8348688 -
Flags: review?(andreea.matei)
Assignee | ||
Comment 18•10 years ago
|
||
Updated the patch.
Attachment #8348637 -
Attachment is obsolete: true
Attachment #8348637 -
Flags: review?(andrei.eftimie)
Attachment #8348637 -
Flags: review?(andreea.matei)
Attachment #8348689 -
Flags: review?(andrei.eftimie)
Attachment #8348689 -
Flags: review?(andreea.matei)
Reporter | ||
Comment 19•10 years ago
|
||
Comment on attachment 8348101 [details] [diff] [review] waitForTabAnimation.patch Review of attachment 8348101 [details] [diff] [review]: ----------------------------------------------------------------- ::: firefox/lib/addons.js @@ +157,5 @@ > } > > + assert.waitFor(function () { > + return self.transitioned; > + }, "Add-ons Manager has been opened", timeout, undefined, this); `timeout` is only declared later in the code. Please remove the last 3 parameters here. We don't need them. We should clean this up. Please make a followup patch to have this fixed. We'll land backports with all final changes.
Attachment #8348101 -
Flags: review-
Assignee | ||
Comment 20•10 years ago
|
||
Followup patch for Default Branch, cleaning up parts of the code that shouldn't be there in the first place.
Attachment #8348702 -
Flags: review?(andrei.eftimie)
Attachment #8348702 -
Flags: review?(andreea.matei)
Comment 21•10 years ago
|
||
Comment on attachment 8348702 [details] [diff] [review] waitForTabAnimation_FollowUp.patch Review of attachment 8348702 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/39901d638d4a (default) The other patches need an update.
Attachment #8348702 -
Flags: review?(andrei.eftimie)
Attachment #8348702 -
Flags: review?(andreea.matei)
Attachment #8348702 -
Flags: review+
Assignee | ||
Comment 22•10 years ago
|
||
Aurora backport patch.
Attachment #8349388 -
Flags: review?(andrei.eftimie)
Attachment #8349388 -
Flags: review?(andreea.matei)
Assignee | ||
Comment 23•10 years ago
|
||
Fixed Beta backport patch.
Attachment #8348688 -
Attachment is obsolete: true
Attachment #8348688 -
Flags: review?(andrei.eftimie)
Attachment #8348688 -
Flags: review?(andreea.matei)
Assignee | ||
Comment 24•10 years ago
|
||
Fixed ESR24 backport patch.
Attachment #8348689 -
Attachment is obsolete: true
Attachment #8348689 -
Flags: review?(andrei.eftimie)
Attachment #8348689 -
Flags: review?(andreea.matei)
Attachment #8349396 -
Flags: review?(andrei.eftimie)
Attachment #8349396 -
Flags: review?(andreea.matei)
Assignee | ||
Updated•10 years ago
|
Attachment #8349393 -
Flags: review?(andrei.eftimie)
Attachment #8349393 -
Flags: review?(andreea.matei)
Comment 25•10 years ago
|
||
Comment on attachment 8349388 [details] [diff] [review] waitForTabAnimation_Aurora.patch Review of attachment 8349388 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/465d259ac182 (aurora)
Attachment #8349388 -
Flags: review?(andrei.eftimie)
Attachment #8349388 -
Flags: review?(andreea.matei)
Attachment #8349388 -
Flags: review+
Comment 26•10 years ago
|
||
Comment on attachment 8349393 [details] [diff] [review] waitForTabAnimation_Beta.patch Review of attachment 8349393 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/fe6b65f6cf81 (beta)
Attachment #8349393 -
Flags: review?(andrei.eftimie)
Attachment #8349393 -
Flags: review?(andreea.matei)
Attachment #8349393 -
Flags: review+
Comment 27•10 years ago
|
||
Comment on attachment 8349396 [details] [diff] [review] waitForTabAnimation_ESR24.patch Review of attachment 8349396 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/13b716c6f589 (release) http://hg.mozilla.org/qa/mozmill-tests/rev/6b5eee9025f6 (esr24) We're done :) Thanks!
Attachment #8349396 -
Flags: review?(andrei.eftimie)
Attachment #8349396 -
Flags: review?(andreea.matei)
Attachment #8349396 -
Flags: review+
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox26:
--- → fixed
status-firefox27:
--- → fixed
status-firefox-esr24:
--- → fixed
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•