Closed
Bug 942802
Opened 11 years ago
Closed 11 years ago
nsDocShell::SetForcedCharset should check its argument
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
|
1.78 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
nsDocShell::SetForcedCharset currently trusts its caller to pass a reasonable argument. Since arbitrary add-ons can supply the argument, it would be safer to actually check the argument to see that it doesn't violate assumptions inside Gecko.
|
Assignee | |
Comment 1•11 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=b34418aafe75
Attachment #8338326 -
Flags: review?(bugs)
|
||
Updated•11 years ago
|
Attachment #8338326 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Thanks. https://hg.mozilla.org/integration/mozilla-inbound/rev/b63e8ed1677b
https://hg.mozilla.org/mozilla-central/rev/b63e8ed1677b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•