942822 - [Australis] Some add-on buttons can't be removed from the toolbar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: sticky-icons.mov

Some items can be dragged, but they won't stay in the panel menu or the customization shelf. Problematic add-ons I found so far:

- Buffer http://bufferapp.com/extras
- 1Password https://agilebits.com/extensions/mac/index.html
- Darrin Heneins experimental Smart Bookmarks add-on

Comment 1

[:Gijs (he/him)]

I think these are all jetpack/SDK add-ons, and they need the SDK part of bug 931092 to be fixed. See https://bugzilla.mozilla.org/show_bug.cgi?id=938995#c8 .

Comment 2

[:Gijs (he/him)]

The UI for non-removable items needing work is bug 879981.

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #2)
> The UI for non-removable items needing work is bug 879981.

Thanks for the pointers!
So if I understand this correctly, Jetpack add-ons can't be removed from the toolbar (i.e. can't be placed in the panel) by default? What is the rationale behind that? It sounds counter-intuitive to me.

Comment 4

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > The UI for non-removable items needing work is bug 879981.
> 
> Thanks for the pointers!
> So if I understand this correctly, Jetpack add-ons can't be removed from the
> toolbar (i.e. can't be placed in the panel) by default? What is the
> rationale behind that? It sounds counter-intuitive to me.

No, it's a bug that they can't be removed. But it's a bug for which a fix is already available in the SDK, it just hasn't been uplifted to mozilla-central yet (well, it was uplifted and then backed out because it or other things (we don't know) in the uplift broke tests). So, fix pending, as it were.

The reason you haven't seen this before is that we used to have another bug that let you move items which weren't marked as being removable (bug 940946). They would just have gone back to their original areas when opening new windows / restarting.

Comment 5

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #4)
> 
> No, it's a bug that they can't be removed. But it's a bug for which a fix is
> already available in the SDK, it just hasn't been uplifted to
> mozilla-central yet (well, it was uplifted and then backed out because it or
> other things (we don't know) in the uplift broke tests). So, fix pending, as
> it were.
> 
> The reason you haven't seen this before is that we used to have another bug
> that let you move items which weren't marked as being removable (bug
> 940946). They would just have gone back to their original areas when opening
> new windows / restarting.

Well that explains a couple of things I've encountered with UX and Nightly so far. Thanks for bearing with my slowness of understanding here :)

Comment 7

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] from comment #5)
> (In reply to :Gijs Kruitbosch from comment #4)
> > 
> > No, it's a bug that they can't be removed. But it's a bug for which a fix is
> > already available in the SDK, it just hasn't been uplifted to
> > mozilla-central yet (well, it was uplifted and then backed out because it or
> > other things (we don't know) in the uplift broke tests). So, fix pending, as
> > it were.
> > 
> > The reason you haven't seen this before is that we used to have another bug
> > that let you move items which weren't marked as being removable (bug
> > 940946). They would just have gone back to their original areas when opening
> > new windows / restarting.
> 
> Well that explains a couple of things I've encountered with UX and Nightly
> so far. Thanks for bearing with my slowness of understanding here :)

Philipp, all these bugs have landed now, can you still reproduce this?

Comment 8

[:Gijs (he/him)]

(Note that Buffer is broken itself, and we can't fix it, see https://bugzilla.mozilla.org/show_bug.cgi?id=935471#c1 )

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

It works now, cool!
I'll write an email to someone at Buffer. Perhaps they can be persuaded into changing their addon.

Comment 10

[Cornel Ionce [:noni]]

Verified as fixed in latest Nightly (build ID: 20140226030202) and latest Aurora (build ID: 20140227004002).